Removed check on execution status on consistency date/time check. Dirty reads need to be taken into consideration when setting waits on new load windows.

Author: RoelantVos

020_DIRECT_Framework/Direct_Framework/Direct_Framework.sqlproj

@@ -70,7 +70,6 @@
     <Folder Include="Reference_Databases" />
   </ItemGroup>
   <ItemGroup>
-    <Build Include="Functions\omd.GetConsistencyDateTime.sql" />
     <Build Include="Functions\omd.GetDependency.sql" />
     <Build Include="Functions\omd.GetModuleLoadWindowDateTime.sql" />
     <Build Include="Functions\omd.GetModuleLoadWindowIdentifier.sql" />
@@ -145,6 +144,7 @@
     <Build Include="Stored Procedures\omd.CreateLoadWindow.sql" />
     <Build Include="Functions\omd.GetModuleAreaByModuleId.sql" />
     <Build Include="Stored Procedures\omd.InsertIntoEventLog.sql" />
+    <Build Include="Stored Procedures\omd.GetConsistencyDateTime.sql" />
   </ItemGroup>
   <ItemGroup>
     <PostDeploy Include="Scripts\Script.PostDeployment.sql" />

020_DIRECT_Framework/Direct_Framework/Stored Procedures/GetConsistencyDateTime.sql renamed to 020_DIRECT_Framework/Direct_Framework/Stored Procedures/omd.GetConsistencyDateTime.sql

@@ -316,9 +316,13 @@ BEGIN
 		  SET @localSqlStatement = 'SELECT @localSourceMaxDateTime=COALESCE(MAX(LOAD_DATETIME),''1900-01-01'')' +
 		                           'FROM '+@localDataObjectSource+' sdo '+
 								   'JOIN omd.MODULE_INSTANCE modinst ON sdo.module_instance_id=modinst.MODULE_INSTANCE_ID '+
-                                   'WHERE modinst.EXECUTION_STATUS_CODE=''S'' ' +
+                                   'WHERE 1=1 '+
+								   '--AND modinst.EXECUTION_STATUS_CODE=''S'' ' +
 								   'AND LOAD_DATETIME <= '''+CONVERT(VARCHAR(100),@MeasurementDateTime)+''''
 
+		  -- Commented out EXECUTION_STATUS_CODE line because uncommitted rows should also be evaluated to prevent gaps in the load windows.
+		  -- Otherwise, status changes made to 'S' later on may be left out of the selection.
+
 	      IF @Debug = 'Y'
             PRINT @localSqlStatement;