syntax fixes applied on CTE run order and create tbl

Author: robjharrison

deployment_extracts/eclipse/live/ssd_deployment_individual_files_tsql/ssd_disability.sql

@@ -7,13 +7,22 @@
 -- =============================================================================
 -- META-ELEMENT: {"type": "create_table"}
 -- =============================================================================
+IF OBJECT_ID('tempdb..#ssd_disability', 'U') IS NOT NULL DROP TABLE #ssd_disability;
 
-CREATE TABLE IF NOT EXISTS ssd_disability
-(
-    disa_table_id           VARCHAR(48) PRIMARY KEY,   -- metadata={"item_ref":"DISA003A"}
-    disa_person_id          VARCHAR(48) NOT NULL,      -- metadata={"item_ref":"DISA001A"}
-    disa_disability_code    VARCHAR(48) NOT NULL       -- metadata={"item_ref":"DISA002A"}
-);
+IF OBJECT_ID('ssd_disability', 'U') IS NOT NULL
+BEGIN
+    IF EXISTS (SELECT 1 FROM ssd_disability)
+        TRUNCATE TABLE ssd_disability;
+END
+ELSE
+BEGIN
+    CREATE TABLE ssd_disability
+    (
+        disa_table_id           VARCHAR(48) PRIMARY KEY,
+        disa_person_id          VARCHAR(48) NOT NULL,
+        disa_disability_code    VARCHAR(48) NOT NULL
+    );
+END
 
 -- =============================================================================
 -- Truncate before reload
@@ -24,23 +33,22 @@ TRUNCATE TABLE ssd_disability;
 -- Load data into ssd_disability
 -- =============================================================================
 
-INSERT INTO ssd_disability (
-    disa_table_id,
-    disa_person_id,
-    disa_disability_code
-)
 ;WITH EXCLUSIONS AS (
-    SELECT
-        PV.PERSONID
+    SELECT PV.PERSONID
     FROM [eclipseDelta].[dbo].[PERSONVIEW] PV
-    WHERE PV.PERSONID IN (1,2,3,4,5,6)    -- hard filter admin/test/duplicate records
-       OR COALESCE(PV.DUPLICATED,'?') = 'DUPLICATE'
+    WHERE PV.PERSONID IN (1,2,3,4,5,6)
+       OR ISNULL(PV.DUPLICATED,'?') = 'DUPLICATE'
        OR UPPER(PV.FORENAME) LIKE '%DUPLICATE%'
        OR UPPER(PV.SURNAME) LIKE '%DUPLICATE%'
 )
+INSERT INTO ssd_disability (
+    disa_table_id,
+    disa_person_id,
+    disa_disability_code
+)
 SELECT
-    CLA.CLASSIFICATIONASSIGNMENTID AS disa_table_id,      -- metadata={"item_ref":"DISA003A"}
-    CLA.PERSONID                   AS disa_person_id,     -- metadata={"item_ref":"DISA001A"}
+    CLA.CLASSIFICATIONASSIGNMENTID AS disa_table_id,
+    CLA.PERSONID                   AS disa_person_id,
     CASE 
          WHEN CLASSIFICATION.NAME = 'No disability' THEN 'NONE'
          WHEN CLASSIFICATION.NAME = 'Mobility' THEN 'MOB'
@@ -59,10 +67,14 @@ SELECT
               OR CLASSIFICATION.NAME = 'Autism spectrum condition'
              THEN 'AUT'
          ELSE 'DDA'
-    END AS disa_disability_code                                       -- metadata={"item_ref":"DISA002A"}
+    END AS disa_disability_code
 FROM [eclipseDelta].[dbo].[CLASSIFICATIONPERSONVIEW] CLA
-LEFT JOIN CLASSIFICATION 
+LEFT JOIN [eclipseDelta].[dbo].[CLASSIFICATION] CLASSIFICATION
     ON CLASSIFICATION.ID = CLA.CLASSIFICATIONCODEID
 WHERE CLA.STATUS NOT IN ('DELETED')
   AND CLA.CLASSIFICATIONPATHID IN (55, 58, 79, 172, 186)
-  AND CLA.PERSONID NOT IN (SELECT PERSONID FROM EXCLUSIONS);
+  AND NOT EXISTS (
+      SELECT 1
+      FROM EXCLUSIONS E
+      WHERE E.PERSONID = CLA.PERSONID
+  );