Skip to content

Commit e89e5f4

Browse files
committed
🦥 zerocopy: remove CloseRead
1 parent f21b20c commit e89e5f4

File tree

5 files changed

+0
-36
lines changed

5 files changed

+0
-36
lines changed

direct/stream.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,6 @@ func (rw *DirectStreamReadWriter) CloseWrite() error {
5959
return rw.rw.CloseWrite()
6060
}
6161

62-
// CloseRead implements the ReadWriter CloseRead method.
63-
func (rw *DirectStreamReadWriter) CloseRead() error {
64-
return rw.rw.CloseRead()
65-
}
66-
6762
// Close implements the ReadWriter Close method.
6863
func (rw *DirectStreamReadWriter) Close() error {
6964
return rw.rw.Close()

httpproxy/client.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -105,11 +105,6 @@ func (rw *directReadBufferedStreamReadWriter) CloseWrite() error {
105105
return rw.rw.CloseWrite()
106106
}
107107

108-
// CloseRead implements [zerocopy.ReadWriter.CloseRead].
109-
func (rw *directReadBufferedStreamReadWriter) CloseRead() error {
110-
return rw.rw.CloseRead()
111-
}
112-
113108
// Close implements [zerocopy.ReadWriter.Close].
114109
func (rw *directReadBufferedStreamReadWriter) Close() error {
115110
return rw.rw.Close()

ss2022/stream.go

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -107,11 +107,6 @@ func (rw *ShadowStreamServerReadWriter) WriteZeroCopy(b []byte, payloadStart, pa
107107
return rw.ShadowStreamWriter.WriteZeroCopy(b, payloadStart, payloadLen)
108108
}
109109

110-
// CloseRead implements the ReadWriter CloseRead method.
111-
func (rw *ShadowStreamServerReadWriter) CloseRead() error {
112-
return rw.rawRW.CloseRead()
113-
}
114-
115110
// CloseWrite implements the ReadWriter CloseWrite method.
116111
func (rw *ShadowStreamServerReadWriter) CloseWrite() error {
117112
return rw.rawRW.CloseWrite()
@@ -200,11 +195,6 @@ func (rw *ShadowStreamClientReadWriter) ReadZeroCopy(b []byte, payloadBufStart,
200195
return rw.ShadowStreamReader.ReadZeroCopy(b, payloadBufStart, payloadBufLen)
201196
}
202197

203-
// CloseRead implements the ReadWriter CloseRead method.
204-
func (rw *ShadowStreamClientReadWriter) CloseRead() error {
205-
return rw.rawRW.CloseRead()
206-
}
207-
208198
// CloseWrite implements the ReadWriter CloseWrite method.
209199
func (rw *ShadowStreamClientReadWriter) CloseWrite() error {
210200
return rw.rawRW.CloseWrite()

zerocopy/stream.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -194,12 +194,6 @@ func relayFallback(w Writer, r Reader, frontHeadroom, rearHeadroom, readMaxPaylo
194194
}
195195
}
196196

197-
// CloseRead provides the CloseRead method.
198-
type CloseRead interface {
199-
// CloseRead indicates to the underlying reader that no further reads will happen.
200-
CloseRead() error
201-
}
202-
203197
// CloseWrite provides the CloseWrite method.
204198
type CloseWrite interface {
205199
// CloseWrite indicates to the underlying writer that no further writes will happen.
@@ -210,7 +204,6 @@ type CloseWrite interface {
210204
type ReadWriter interface {
211205
Reader
212206
Writer
213-
CloseRead
214207
CloseWrite
215208
io.Closer
216209
}
@@ -241,7 +234,6 @@ func TwoWayRelay(left, right ReadWriter) (nl2r, nr2l int64, err error) {
241234
// DirectReadWriteCloser extends io.ReadWriteCloser with CloseRead and CloseWrite.
242235
type DirectReadWriteCloser interface {
243236
io.ReadWriteCloser
244-
CloseRead
245237
CloseWrite
246238
}
247239

zerocopy/stream_test.go

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -136,10 +136,6 @@ func (rw *testReadWriterImpl) RearHeadroom() int {
136136
return 0
137137
}
138138

139-
func (rw *testReadWriterImpl) CloseRead() error {
140-
return nil
141-
}
142-
143139
func (rw *testReadWriterImpl) CloseWrite() error {
144140
return nil
145141
}
@@ -177,10 +173,6 @@ func (rw *testDirectReadWriter) RearHeadroom() int {
177173
return 0
178174
}
179175

180-
func (rw *testDirectReadWriter) CloseRead() error {
181-
return nil
182-
}
183-
184176
func (rw *testDirectReadWriter) CloseWrite() error {
185177
return nil
186178
}

0 commit comments

Comments
 (0)