-
Notifications
You must be signed in to change notification settings - Fork 2
Closed
Description
Up to now, we haven't configured dockerhub_username and dockerhub_password yet in the project. We should add support for publishing images in CI when the secrets are ready:
databend-operator/.github/workflows/build-and-push-images.yaml
Lines 23 to 46 in 5a5db5d
| # TODO(Electronic-Waste): Uncomment the following steps when | |
| # - name: Docker Login | |
| # # Trigger workflow only for databendcloud/databend-operator repository with specific branch (master, release-*) or tag (v.*). | |
| # if: >- | |
| # github.repository == 'databendcloud/databend-operator' && | |
| # (github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/heads/release-') || startsWith(github.ref, 'refs/tags/v')) | |
| # uses: docker/login-action@v3 | |
| # with: | |
| # username: ${{ secrets.DOCKERHUB_USERNAME }} | |
| # password: ${{ secrets.DOCKERHUB_TOKEN }} | |
| # - name: Publish Component ${{ matrix.component-name }} | |
| # # Trigger workflow only for databendcloud/databend-operator repository with specific branch (master, release-*) or tag (v.*). | |
| # if: >- | |
| # github.repository == 'databendcloud/databend-operator' && | |
| # (github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/heads/release-') || startsWith(github.ref, 'refs/tags/v')) | |
| # id: publish | |
| # uses: ./.github/workflows/template-publish-image | |
| # with: | |
| # image: docker.io/datafuselabs/${{ matrix.component-name }} | |
| # dockerfile: ${{ matrix.dockerfile }} | |
| # platforms: ${{ matrix.platforms }} | |
| # context: ${{ matrix.context }} | |
| # push: true |
This is the only thing to be done before the first release of databend-operator.
/cc @flaneur2020 @hantmac
Metadata
Metadata
Assignees
Labels
No labels