feat: timezone_tz map to Date in nodejs binding.

Author: youngsofun

bindings/nodejs/src/lib.rs

@@ -24,8 +24,6 @@ use std::sync::Arc;
 use std::{collections::HashMap, path::Path};
 use tokio_stream::StreamExt;
 
-const TIMESTAMP_TIMEZONE_FORMAT: &str = "%Y-%m-%d %H:%M:%S%.6f %z";
-
 static VERSION: Lazy<String> = Lazy::new(|| {
     let version = option_env!("CARGO_PKG_VERSION").unwrap_or("unknown");
     version.to_string()
@@ -326,8 +324,13 @@ impl ToNapiValue for Value<'_> {
                 Ok(js_date)
             }
             databend_driver::Value::TimestampTz(dt) => {
-                let formatted = dt.strftime(TIMESTAMP_TIMEZONE_FORMAT);
-                String::to_napi_value(env, formatted.to_string())
+                let mut js_date = std::ptr::null_mut();
+                let millis = dt.timestamp().as_millisecond() as f64;
+                check_status!(
+                    unsafe { sys::napi_create_date(env, millis, &mut js_date) },
+                    "Failed to convert jiff timestamp into napi value",
+                )?;
+                Ok(js_date)
             }
             databend_driver::Value::Date(_) => {
                 let inner = val.inner.clone();

bindings/nodejs/tests/binding.js

@@ -52,6 +52,7 @@ Given("A new Databend Driver Client", async function () {
     assert.fail("No connection returned");
   }
   this.conn = conn;
+  conn.exec("set timezone='Asia/Shanghai'")
 });
 
 Then("Select string {string} should be equal to {string}", async function (input, output) {
@@ -143,7 +144,7 @@ Then("Select types should be expected native types", async function () {
     const row = await this.conn.queryRow(
       "SELECT to_datetime('2020-01-01 12:34:56.789'), to_datetime('2020-01-02 12:34:56.789')",
     );
-    assert.deepEqual(row.values(), [new Date("2020-01-01T12:34:56.789Z"), new Date("2020-01-02T12:34:56.789Z")]);
+    assert.deepEqual(row.values(), [new Date("2020-01-01T04:34:56.789Z"), new Date("2020-01-02T04:34:56.789Z")]);
   }
 
   // VARCHAR
@@ -166,8 +167,10 @@ Then("Select types should be expected native types", async function () {
 
   // TUPLE
   {
-    const row = await this.conn.queryRow(`SELECT (10, '20', to_datetime('2024-04-16 12:34:56.789'))`);
-    assert.deepEqual(row.values(), [[10, "20", new Date("2024-04-16T12:34:56.789Z")]]);
+    const row = await this.conn.queryRow(
+      `SELECT (10, '20', to_datetime('2024-04-16 12:34:56.789'))`,
+    );
+    assert.deepEqual(row.values(), [[10, "20", new Date("2024-04-16T04:34:56.789Z")]]);
   }
 
   // MAP
@@ -220,7 +223,7 @@ Then("Select types should be expected native types", async function () {
   // TimestampTz
   if (!(DRIVER_VERSION > [0, 30, 3] && DB_VERSION >= [1, 2, 836])) {
     const row = await this.conn.queryRow(`SELECT to_datetime_tz('2024-04-16 12:34:56.789 +0800'))`);
-    assert.deepEqual(row.values(), ["2024-04-16T12:34:56.789 +0800"]);
+    assert.deepEqual(row.values(), [new Date("2024-04-16 04:34:56.789Z")]);
   }
 });
 
@@ -310,9 +313,9 @@ Then("Insert and Select should be equal", async function () {
     ret.push(row.values());
   }
   const expected = [
-    [-1, 1, 1.0, "'", null, new Date("2011-03-06"), new Date("2011-03-06T06:20:00Z")],
-    [-2, 2, 2.0, '"', "", new Date("2012-05-31"), new Date("2012-05-31T11:20:00Z")],
-    [-3, 3, 3.0, "\\", "NULL", new Date("2016-04-04"), new Date("2016-04-04T11:30:00Z")],
+    [-1, 1, 1.0, "'", null, new Date("2011-03-06"), new Date("2011-03-05T22:20:00Z")],
+    [-2, 2, 2.0, '"', "", new Date("2012-05-31"), new Date("2012-05-31T03:20:00Z")],
+    [-3, 3, 3.0, "\\", "NULL", new Date("2016-04-04"), new Date("2016-04-04T03:30:00Z")],
   ];
   assert.deepEqual(ret, expected);
 });
@@ -353,16 +356,16 @@ Then("Load file with Stage and Select should be equal", async function () {
     ret.push(row.values());
   }
   const expected = [
-    [-1, 1, 1.0, "'", null, new Date("2011-03-06"), new Date("2011-03-06T06:20:00Z")],
-    [-2, 2, 2.0, '"', null, new Date("2012-05-31"), new Date("2012-05-31T11:20:00Z")],
-    [-3, 3, 3.0, "\\", "NULL", new Date("2016-04-04"), new Date("2016-04-04T11:30:00Z")],
+    [-1, 1, 1.0, "'", null, new Date("2011-03-06"), new Date("2011-03-05T22:20:00Z")],
+    [-2, 2, 2.0, '"', null, new Date("2012-05-31"), new Date("2012-05-31T03:20:00Z")],
+    [-3, 3, 3.0, "\\", "NULL", new Date("2016-04-04"), new Date("2016-04-04T03:30:00Z")],
   ];
   assert.deepEqual(ret, expected);
 });
 
 Then("Load file with Streaming and Select should be equal", async function () {
   const progress = await this.conn.loadFile(
-    `INSERT INTO test VALUES from @_databend_load file_format=(type=csv)`,
+    `INSERT /*+SET_VAR(timezone='Asia/Shanghai')*/ INTO test VALUES from @_databend_load file_format=(type=csv)`,
     "tests/data/test.csv",
     "streaming",
   );
@@ -374,9 +377,9 @@ Then("Load file with Streaming and Select should be equal", async function () {
     ret.push(row.values());
   }
   const expected = [
-    [-1, 1, 1.0, "'", null, new Date("2011-03-06"), new Date("2011-03-06T06:20:00Z")],
-    [-2, 2, 2.0, '"', null, new Date("2012-05-31"), new Date("2012-05-31T11:20:00Z")],
-    [-3, 3, 3.0, "\\", "NULL", new Date("2016-04-04"), new Date("2016-04-04T11:30:00Z")],
+    [-1, 1, 1.0, "'", null, new Date("2011-03-06"), new Date("2011-03-05T22:20:00Z")],
+    [-2, 2, 2.0, '"', null, new Date("2012-05-31"), new Date("2012-05-31T03:20:00Z")],
+    [-3, 3, 3.0, "\\", "NULL", new Date("2016-04-04"), new Date("2016-04-04T03:30:00Z")],
   ];
   assert.deepEqual(ret, expected);
 });