Merge pull request #10650 from RinChanNOWWW/check-view-dep

fix: avoid dependency loop when selecting from view.

Author: BohuTANG

src/query/sql/src/planner/binder/bind_context.rs

@@ -135,7 +135,10 @@ pub struct BindContext {
 
     pub ctes_map: Box<DashMap<String, CteInfo>>,
 
-    pub is_view: bool,
+    /// If current binding table is a view, record its database and name.
+    ///
+    /// It's used to check if the view has a loop dependency.
+    pub view_info: Option<(String, String)>,
 }
 
 #[derive(Clone, Debug)]
@@ -154,7 +157,7 @@ impl BindContext {
             windows: Vec::new(),
             in_grouping: false,
             ctes_map: Box::new(DashMap::new()),
-            is_view: false,
+            view_info: None,
         }
     }
 
@@ -167,7 +170,7 @@ impl BindContext {
             windows: vec![],
             in_grouping: false,
             ctes_map: parent.ctes_map.clone(),
-            is_view: false,
+            view_info: None,
         }
     }
 

src/query/sql/src/planner/binder/table.rs

@@ -117,6 +117,25 @@ impl Binder {
             .await
     }
 
+    fn check_view_dep(bind_context: &BindContext, database: &str, view_name: &str) -> Result<()> {
+        match &bind_context.parent {
+            Some(parent) => match &parent.view_info {
+                Some((db, v)) => {
+                    if db == database && v == view_name {
+                        Err(ErrorCode::Internal(format!(
+                            "View dependency loop detected (view: {}.{})",
+                            database, view_name
+                        )))
+                    } else {
+                        Self::check_view_dep(parent, database, view_name)
+                    }
+                }
+                _ => Ok(()),
+            },
+            _ => Ok(()),
+        }
+    }
+
     #[async_recursion]
     async fn bind_single_table(
         &mut self,
@@ -191,6 +210,7 @@ impl Binder {
 
                 match table_meta.engine() {
                     "VIEW" => {
+                        Self::check_view_dep(bind_context, &database, &table_name)?;
                         let query = table_meta
                             .options()
                             .get(QUERY)
@@ -200,7 +220,8 @@ impl Binder {
                         // For view, we need use a new context to bind it.
                         let mut new_bind_context =
                             BindContext::with_parent(Box::new(bind_context.clone()));
-                        new_bind_context.is_view = true;
+                        new_bind_context.view_info =
+                            Some((database.clone(), table_name.to_string()));
                         if let Statement::Query(query) = &stmt {
                             self.metadata.write().add_table(
                                 catalog,
@@ -239,7 +260,7 @@ impl Binder {
                             database.clone(),
                             table_meta,
                             table_alias_name,
-                            bind_context.is_view,
+                            bind_context.view_info.is_some(),
                         );
 
                         let (s_expr, mut bind_context) = self
@@ -529,7 +550,7 @@ impl Binder {
             windows: vec![],
             in_grouping: false,
             ctes_map: Box::new(DashMap::new()),
-            is_view: false,
+            view_info: None,
         };
         let (s_expr, mut new_bind_context) =
             self.bind_query(&new_bind_context, &cte_info.query).await?;

tests/sqllogictests/suites/base/05_ddl/05_0019_ddl_create_view

@@ -111,3 +111,39 @@ AS
     SELECT *
     FROM
         's3://testbucket/admin/data/tuple.parquet' (FILES => ('tuple.parquet','test.parquet'),FILE_FORMAT => 'parquet',PATTERN => '.*.parquet', aws_key_id => 'minioadmin', aws_secret_key => 'minioadmin', endpoint_url => 'http://127.0.0.1:9900/')
+
+statement ok
+drop view if exists loop_view1;
+
+statement ok
+drop view if exists loop_view2;
+
+statement ok
+drop view if exists loop_view3;
+
+statement ok
+create view loop_view1 as select * from loop_view3;
+
+statement ok
+create view loop_view2 as select * from loop_view1;
+
+statement ok
+create view loop_view3 as select * from loop_view2;
+
+statement error 1001
+select * from loop_view1;
+
+statement error 1001
+select * from loop_view2;
+
+statement error 1001
+select * from loop_view2;
+
+statement ok
+drop view loop_view1;
+
+statement ok
+drop view loop_view2;
+
+statement ok
+drop view loop_view3;