fix: the result of the first parameter of eval_or_filters will affect the subsequent parameters (#18782)

Author: KKould

src/query/expression/src/evaluator.rs

@@ -1420,11 +1420,12 @@ impl<'a> Evaluator<'a> {
     fn eval_or_filters(
         &self,
         args: &[Expr],
-        mut validity: Option<Bitmap>,
+        validity: Option<Bitmap>,
         options: &mut EvaluateOptions,
     ) -> Result<Value<AnyType>> {
         assert!(args.len() >= 2);
 
+        let mut result = validity.clone();
         for arg in args {
             let cond = self.partial_run(arg, validity.clone(), options)?;
             match &cond {
@@ -1443,20 +1444,20 @@ impl<'a> Evaluator<'a> {
                         Column::Boolean(boolean_column) => boolean_column.clone(),
                         _ => unreachable!(),
                     };
-                    match &validity {
+                    match &result {
                         Some(v) => {
-                            validity = Some(v | (&flag));
+                            result = Some(v | (&flag));
                         }
                         None => {
-                            validity = Some(flag);
+                            result = Some(flag);
                         }
                     }
                 }
                 _ => unreachable!(),
             }
         }
 
-        match validity {
+        match result {
             Some(bitmap) => Ok(Value::Column(Column::Boolean(bitmap))),
             None => Ok(Value::Scalar(Scalar::Boolean(false))),
         }

tests/sqllogictests/suites/base/03_common/03_0025_delete_from.test

@@ -355,5 +355,46 @@ select count(*) from t;
 statement ok
 drop table t all
 
+statement ok
+CREATE OR REPLACE TABLE test_delete_or_filters (group_flag VARCHAR NULL, af_cohort_install DOUBLE NULL) ENGINE=FUSE;
+
+statement ok
+INSERT INTO test_delete_or_filters
+VALUES ('af_cohort_retained', 50594),
+       ('af_cohort_retained', 49465),
+       ('af_cohort_retained', 49176),
+       ('af_cohort_retained', 48575),
+       ('af_cohort_retained', 53555),
+       ('af_cohort_retained', 54150),
+       ('af_cohort_receipt', 50594),
+       ('af_cohort_receipt', 49465),
+       ('af_cohort_receipt', 49176),
+       ('af_cohort_receipt', 48575),
+       ('af_cohort_receipt', 53555),
+       ('af_cohort_receipt', 54150),
+       ('af_cohort_deposit', 25000),
+       ('af_cohort_deposit', 24500),
+       ('af_cohort_deposit', 24000),
+       ('af_cohort_deposit', 23500),
+       ('af_cohort_deposit', 26000),
+       ('af_cohort_deposit', 27000),
+       ('af_cohort_deposit', 25500),
+       ('af_cohort_deposit', 26500),
+       ('normal_data', 10000),
+       ('normal_data', 11000),
+       ('normal_data', 12000),
+       ('normal_data', 13000);
+
+statement ok
+delete from test_delete_or_filters where group_flag in ('af_cohort_deposit', 'af_cohort_receipt', 'af_cohort_retained');
+
+query TI
+select * from test_delete_or_filters;
+----
+normal_data 10000.0
+normal_data 11000.0
+normal_data 12000.0
+normal_data 13000.0
+
 statement ok
 DROP DATABASE db1