chore(query): remove SliceExt (#16853)

* chore(query): remove SliceExt

* chore(query): remove SliceExt

Author: sundy-li

src/common/base/src/lib.rs

@@ -36,7 +36,6 @@ pub mod http_client;
 pub mod mem_allocator;
 pub mod rangemap;
 pub mod runtime;
-pub mod slice_ext;
 pub mod vec_ext;
 pub mod version;
 

src/common/base/src/slice_ext.rs

@@ -19,7 +19,6 @@ use databend_common_arrow::arrow::array::Array;
 use databend_common_arrow::arrow::array::Utf8ViewArray;
 use databend_common_arrow::arrow::bitmap::Bitmap;
 use databend_common_arrow::arrow::buffer::Buffer;
-use databend_common_base::slice_ext::GetSaferUnchecked;
 use databend_common_exception::Result;
 use string::StringColumnBuilder;
 
@@ -258,7 +257,7 @@ where I: databend_common_arrow::arrow::types::Index
         let result: Vec<T> = self
             .indices
             .iter()
-            .map(|index| unsafe { *col.get_unchecked_release(index.to_usize()) })
+            .map(|index| unsafe { *col.get_unchecked(index.to_usize()) })
             .collect();
         result.into()
     }

src/query/expression/src/kernels/take.rs

@@ -18,7 +18,6 @@ use std::ops::Range;
 use databend_common_arrow::arrow::array::MutableBinaryViewArray;
 use databend_common_arrow::arrow::array::Utf8ViewArray;
 use databend_common_arrow::arrow::trusted_len::TrustedLen;
-use databend_common_base::slice_ext::GetSaferUnchecked;
 use databend_common_exception::ErrorCode;
 use databend_common_exception::Result;
 
@@ -293,8 +292,8 @@ impl StringColumn {
     }
 
     pub fn compare(col_i: &Self, i: usize, col_j: &Self, j: usize) -> Ordering {
-        let view_i = unsafe { col_i.data.views().as_slice().get_unchecked_release(i) };
-        let view_j = unsafe { col_j.data.views().as_slice().get_unchecked_release(j) };
+        let view_i = unsafe { col_i.data.views().as_slice().get_unchecked(i) };
+        let view_j = unsafe { col_j.data.views().as_slice().get_unchecked(j) };
 
         if view_i.prefix == view_j.prefix {
             unsafe {
@@ -311,7 +310,7 @@ impl StringColumn {
     }
 
     pub fn compare_str(col: &Self, i: usize, value: &str) -> Ordering {
-        let view = unsafe { col.data.views().as_slice().get_unchecked_release(i) };
+        let view = unsafe { col.data.views().as_slice().get_unchecked(i) };
         let prefix = load_prefix(value.as_bytes());
 
         if view.prefix == prefix {