chore: Bump Rust toolchain to nightly-2025-04-04 (#17752)

* Save work

Signed-off-by: Xuanwo <[email protected]>

* Save work

Signed-off-by: Xuanwo <[email protected]>

* Save work

Signed-off-by: Xuanwo <[email protected]>

---------

Signed-off-by: Xuanwo <[email protected]>

Author: Xuanwo

Cargo.toml

@@ -574,6 +574,7 @@ async_fn_in_trait = "allow"
 useless_format = "allow"
 mutable_key_type = "allow"
 result_large_err = "allow"
+map_entry = "allow"
 
 ## DONT'T DELETE THIS: If we want best performance, we should use this profile but it will take longer time to compile.
 ## Test SQL:

rust-toolchain.toml

@@ -1,3 +1,3 @@
 [toolchain]
-channel = "nightly-2024-11-28"
+channel = "nightly-2025-04-04"
 components = ["rustfmt", "clippy", "rust-src", "miri", "rust-analyzer"]

src/common/auth/src/auth.rs

@@ -35,8 +35,7 @@ pub struct TokenFile {
 
 impl TokenFile {
     pub fn new(path: &Path) -> Result<Self, Error> {
-        let token =
-            std::fs::read_to_string(path).map_err(|err| Error::new(ErrorKind::Other, err))?;
+        let token = std::fs::read_to_string(path).map_err(Error::other)?;
         Ok(Self {
             path: path.to_path_buf(),
             token,

src/common/base/src/base/dma.rs

@@ -279,7 +279,7 @@ impl DmaFile {
         match rustix::io::write(&self.fd, buf) {
             Ok(n) => {
                 if n != buf.len() {
-                    return Err(io::Error::new(io::ErrorKind::Other, "short write"));
+                    return Err(io::Error::other("short write"));
                 }
                 self.mut_buffer().clear();
                 Ok(n)
@@ -292,7 +292,7 @@ impl DmaFile {
         let Self { fd, buf, .. } = self;
         let buf = buf.as_mut().unwrap();
         if n > buf.capacity() - buf.len() {
-            return Err(io::Error::new(io::ErrorKind::Other, "buf not sufficient"));
+            return Err(io::Error::other("buf not sufficient"));
         }
         let start = buf.len();
         unsafe { buf.set_len(buf.len() + n) };
@@ -341,10 +341,7 @@ where
 {
     match spawn_blocking(f).await {
         Ok(res) => res,
-        Err(_) => Err(io::Error::new(
-            io::ErrorKind::Other,
-            "background task failed",
-        )),
+        Err(_) => Err(io::Error::other("background task failed")),
     }
 }
 

src/common/base/src/obfuscator.rs

@@ -311,11 +311,8 @@ where
         let mut hash = std::hash::DefaultHasher::new();
         hash.write_u64(seed);
 
-        let sliding_window_overflow = if written + sliding_window_size > determinator_size {
-            written + sliding_window_size - determinator_size
-        } else {
-            0
-        };
+        let sliding_window_overflow =
+            (written + sliding_window_size).saturating_sub(determinator_size);
 
         let start = written - sliding_window_overflow;
         let end = start + sliding_window_size;

src/common/base/src/runtime/global_runtime.rs

@@ -25,7 +25,7 @@ pub struct GlobalQueryRuntime(pub Runtime);
 
 impl GlobalQueryRuntime {
     #[inline(always)]
-    pub fn runtime<'a>(self: &'a Arc<Self>) -> &'a Runtime {
+    pub fn runtime(self: &Arc<Self>) -> &Runtime {
         &self.0
     }
 }

src/common/cloud_control/build.rs

@@ -19,7 +19,6 @@
 use std::env;
 use std::fs;
 use std::io::Error;
-use std::io::ErrorKind;
 use std::io::Result;
 use std::path::Path;
 use std::process::Command;
@@ -48,32 +47,31 @@ fn build_proto() -> Result<()> {
     let output = cmd.output()?;
     let version = if output.status.success() {
         let content = String::from_utf8_lossy(&output.stdout);
-        let content = content.trim().split(' ').last().ok_or_else(|| {
-            Error::new(
-                ErrorKind::Other,
-                format!("protoc --version got unexpected output: {}", content),
-            )
+        let content = content.trim().split(' ').next_back().ok_or_else(|| {
+            Error::other(format!(
+                "protoc --version got unexpected output: {}",
+                content
+            ))
         })?;
         lenient_semver::parse(content).map_err(|err| {
-            Error::new(
-                ErrorKind::Other,
-                format!("protoc --version doesn't return valid version: {:?}", err),
-            )
+            Error::other(format!(
+                "protoc --version doesn't return valid version: {:?}",
+                err
+            ))
         })?
     } else {
-        return Err(Error::new(
-            ErrorKind::Other,
-            format!("protoc failed: {}", String::from_utf8_lossy(&output.stderr)),
-        ));
+        return Err(Error::other(format!(
+            "protoc failed: {}",
+            String::from_utf8_lossy(&output.stderr)
+        )));
     };
 
     let mut config = prost_build::Config::new();
     config.btree_map(["."]);
 
     // Version before 3.12 doesn't support allow_proto3_optional
     if version < Version::new(3, 12, 0) {
-        return Err(Error::new(
-            ErrorKind::Other,
+        return Err(Error::other(
             format!(
                 "protoc version is outdated, expect: >= 3.12.0, actual: {version}, reason: need feature --experimental_allow_proto3_optional"
             ),

src/common/cloud_control/tests/it/task_client.rs

@@ -179,10 +179,7 @@ async fn test_task_client_success_cases() -> Result<()> {
                 if let Some(client) = client {
                     Ok(client)
                 } else {
-                    Err(std::io::Error::new(
-                        std::io::ErrorKind::Other,
-                        "Client already taken",
-                    ))
+                    Err(std::io::Error::other("Client already taken"))
                 }
             }
         }))

src/common/column/src/binview/builder.rs

@@ -197,7 +197,7 @@ impl<T: ViewType + ?Sized> BinaryViewColumnBuilder<T> {
         self.push_value(value);
         let value = self.views.pop().unwrap();
         self.total_bytes_len = old_bytes_len + value.length as usize * additional;
-        self.views.extend(std::iter::repeat(value).take(additional));
+        self.views.extend(std::iter::repeat_n(value, additional));
     }
 
     #[inline]

src/common/column/src/binview/mod.rs

@@ -345,7 +345,7 @@ impl<T: ViewType + ?Sized> BinaryViewColumnGeneric<T> {
     }
 
     pub fn is_sliced(&self) -> bool {
-        self.views.as_ptr() != self.views.data_ptr()
+        !std::ptr::eq(self.views.as_ptr(), self.views.data_ptr())
     }
 
     fn slice(&mut self, offset: usize, length: usize) {