Skip to content

Commit 22e8705

Browse files
committed
chore: add some annotations for bugfix
1 parent c4786b6 commit 22e8705

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

src/query/service/src/pipelines/pipeline_builder.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -829,7 +829,6 @@ impl PipelineBuilder {
829829
|| join.join_type == JoinType::Single)
830830
&& join.non_equi_conditions.is_empty()
831831
{
832-
// self.main_pipeline.resize(1)?;
833832
self.main_pipeline.add_transform(|input, output| {
834833
let transform = TransformLeftJoin::try_create(
835834
input,

src/query/service/src/pipelines/processors/transforms/transform_left_join.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,8 @@ impl Compactor for LeftJoinCompactor {
5353

5454
// `compact_final` is called when all the blocks are pushed
5555
fn compact_final(&self, blocks: &[DataBlock]) -> Result<Vec<DataBlock>> {
56+
// If upstream data block is small, all blocks will be in rest blocks
57+
// So compact partial won't be triggered, we still need to compact final here.
5658
self.hash_join_state.left_join_blocks(blocks)
5759
}
5860
}

0 commit comments

Comments
 (0)