fix(query): domain calc for int64 to timestamp is incorrect (#18597)

If timestamp is not in a valid socpe will cast it into timestamp::MIN or timestamp::MIN

Author: TCeason

src/query/functions/src/scalars/timestamp/src/datetime.rs

@@ -141,27 +141,40 @@ pub fn int64_to_timestamp(mut n: i64) -> i64 {
     }
 }
 
+/// calc int64 domain to timestamp domain
 #[inline]
-pub fn int32_to_timestamp(n: i32) -> i64 {
+pub fn calc_int64_to_timestamp_domain(n: i64) -> i64 {
+    if -31536000000 < n && n < 31536000000 {
+        n * MICROS_PER_SEC
+    } else if -31536000000000 < n && n < 31536000000000 {
+        n * MICROS_PER_MILLI
+    } else {
+        n.clamp(TIMESTAMP_MIN, TIMESTAMP_MAX)
+    }
+}
+
+/// calc int32 domain to timestamp domain
+#[inline]
+pub fn calc_int32_to_timestamp_domain(n: i32) -> i64 {
     let n = n as i64 * 24 * 3600 * MICROS_PER_SEC;
-    int64_to_timestamp(n)
+    calc_int64_to_timestamp_domain(n)
 }
 
 fn int32_domain_to_timestamp_domain<T: AsPrimitive<i32>>(
     domain: &SimpleDomain<T>,
 ) -> Option<SimpleDomain<i64>> {
     Some(SimpleDomain {
-        min: int32_to_timestamp(domain.min.as_()),
-        max: int32_to_timestamp(domain.max.as_()),
+        min: calc_int32_to_timestamp_domain(domain.min.as_()),
+        max: calc_int32_to_timestamp_domain(domain.max.as_()),
     })
 }
 
 fn int64_domain_to_timestamp_domain<T: AsPrimitive<i64>>(
     domain: &SimpleDomain<T>,
 ) -> Option<SimpleDomain<i64>> {
     Some(SimpleDomain {
-        min: int64_to_timestamp(domain.min.as_()),
-        max: int64_to_timestamp(domain.max.as_()),
+        min: calc_int64_to_timestamp_domain(domain.min.as_()),
+        max: calc_int64_to_timestamp_domain(domain.max.as_()),
     })
 }
 

src/query/functions/tests/it/scalars/datetime.rs

@@ -64,6 +64,11 @@ fn test_to_timestamp(file: &mut impl Write) {
         ]),
     )]);
 
+    run_ast(file, "to_timestamp(a) > '2020-01-01'", &[(
+        "a",
+        Int64Type::from_data(vec![i64::MIN, i64::MAX]),
+    )]);
+
     run_ast(file, "to_timestamp(b)", &[(
         "b",
         StringType::from_data(vec!["2020-01-01", "2020-01-02", "2020-01-03", "2029-01-01"]),

src/query/functions/tests/it/scalars/testdata/datetime.txt

@@ -132,6 +132,28 @@ evaluation (internal):
 +--------+------------------------------------------------------------------------------------------------------------+
 
 
+ast            : to_timestamp(a) > '2020-01-01'
+raw expr       : gt(to_timestamp(a::Int64), '2020-01-01')
+checked expr   : gt<Timestamp, Timestamp>(CAST<Int64>(a AS Timestamp), CAST<String>("2020-01-01" AS Timestamp))
+optimized expr : gt<Timestamp, Timestamp>(CAST<Int64>(a AS Timestamp), 1577836800000000)
+evaluation:
++--------+----------------------------------------------+---------------+
+|        | a                                            | Output        |
++--------+----------------------------------------------+---------------+
+| Type   | Int64                                        | Boolean       |
+| Domain | {-9223372036854775808..=9223372036854775807} | {FALSE, TRUE} |
+| Row 0  | -9223372036854775808                         | false         |
+| Row 1  | 9223372036854775807                          | false         |
++--------+----------------------------------------------+---------------+
+evaluation (internal):
++--------+----------------------------------------------------+
+| Column | Data                                               |
++--------+----------------------------------------------------+
+| a      | Int64([-9223372036854775808, 9223372036854775807]) |
+| Output | Boolean([0b______00])                              |
++--------+----------------------------------------------------+
+
+
 ast            : to_timestamp(b)
 raw expr       : to_timestamp(b::String)
 checked expr   : CAST<String>(b AS Timestamp)