fix(query): fix clone_expr_with_replacement (#18088)

* fix(query): fix clone_expr_with_replacement

* fix(query): fix clone_expr_with_replacement

Author: sundy-li

src/query/ast/src/parser/expr.rs

@@ -1626,19 +1626,22 @@ pub fn type_name(i: Input) -> IResult<TypeName> {
         rule! { (FLOAT64 | DOUBLE)  ~ PRECISION? },
     );
     let ty_decimal = map_res(
-        rule! { DECIMAL ~ "(" ~ #literal_u64 ~ ( "," ~ ^#literal_u64 )? ~ ")" },
-        |(_, _, precision, opt_scale, _)| {
+        rule! { DECIMAL ~ ( "(" ~ #literal_u64 ~ ( "," ~ ^#literal_u64 )? ~ ")" )? },
+        |(_, opt_precision)| {
+            let (precision, scale) = match opt_precision {
+                Some((_, precision, scale, _)) => {
+                    (precision, scale.map(|(_, scale)| scale).unwrap_or(0))
+                }
+                None => (18, 3),
+            };
+
             Ok(TypeName::Decimal {
                 precision: precision
                     .try_into()
                     .map_err(|_| nom::Err::Failure(ErrorKind::Other("precision is too large")))?,
-                scale: if let Some((_, scale)) = opt_scale {
-                    scale
-                        .try_into()
-                        .map_err(|_| nom::Err::Failure(ErrorKind::Other("scale is too large")))?
-                } else {
-                    0
-                },
+                scale: scale
+                    .try_into()
+                    .map_err(|_| nom::Err::Failure(ErrorKind::Other("scale is too large")))?,
             })
         },
     );

src/query/ast/tests/it/parser.rs

@@ -958,7 +958,6 @@ fn test_statement_error() {
         r#"create table a (c float(10))"#,
         r#"create table a (c varch)"#,
         r#"create table a (c tuple())"#,
-        r#"create table a (c decimal)"#,
         r#"create table a (b tuple(c int, uint64));"#,
         r#"CREATE TABLE t(c1 NULLABLE(int) NOT NULL);"#,
         r#"create table a (c1 decimal(38), c2 int) partition by ();"#,

src/query/ast/tests/it/testdata/stmt-error.txt

@@ -49,20 +49,6 @@ error:
   | while parsing `CREATE [OR REPLACE] TABLE [IF NOT EXISTS] [<database>.]<table> [<source>] [<table_options>]`
 
 
----------- Input ----------
-create table a (c decimal)
----------- Output ---------
-error: 
-  --> SQL:1:26
-  |
-1 | create table a (c decimal)
-  | ------          - -------^ unexpected `)`, expecting `(`
-  | |               | |       
-  | |               | while parsing type name
-  | |               while parsing `<column name> <type> [DEFAULT <expr>] [AS (<expr>) VIRTUAL] [AS (<expr>) STORED] [COMMENT '<comment>']`
-  | while parsing `CREATE [OR REPLACE] TABLE [IF NOT EXISTS] [<database>.]<table> [<source>] [<table_options>]`
-
-
 ---------- Input ----------
 create table a (b tuple(c int, uint64));
 ---------- Output ---------