chore(query): last_day support default interval type (#18022)

refactor: last_day support default interval type

LAST_DAY( <date_or_timetamp_expr> [ , <date_part> ] )

The interval type for which to find the last day. Accepted values are week, month, quarter, and year.

default with: month

Author: TCeason

src/query/ast/src/parser/expr.rs

@@ -1216,9 +1216,18 @@ pub fn expr_element(i: Input) -> IResult<WithSpan<ExprElement>> {
 
     let last_day = map(
         rule! {
-            LAST_DAY ~ "(" ~ #subexpr(0) ~ "," ~ #interval_kind ~ ")"
+            LAST_DAY ~ "(" ~ #subexpr(0) ~ ("," ~ #interval_kind)? ~ ")"
+        },
+        |(_, _, date, opt_unit, _)| {
+            if let Some((_, unit)) = opt_unit {
+                ExprElement::LastDay { unit, date }
+            } else {
+                ExprElement::LastDay {
+                    unit: IntervalKind::Month,
+                    date,
+                }
+            }
         },
-        |(_, _, date, _, unit, _)| ExprElement::LastDay { unit, date },
     );
 
     let previous_day = map(

src/query/ast/tests/it/parser.rs

@@ -1265,6 +1265,8 @@ fn test_expr() {
         r#"date_part(year, d)"#,
         r#"datepart(year, d)"#,
         r#"DATEDIFF(SECOND, to_timestamp('2024-01-01 21:01:35.423179'), to_timestamp('2023-12-31 09:38:18.165575'))"#,
+        r#"last_day(to_date('2024-10-22'), week)"#,
+        r#"last_day(to_date('2024-10-22'))"#,
         r#"date_sub(QUARTER, 1, to_date('2018-01-02'))"#,
         r#"datebetween(QUARTER, to_date('2018-01-02'), to_date('2018-04-02'))"#,
         r#"position('a' in str)"#,

src/query/ast/tests/it/testdata/expr.txt

@@ -1915,6 +1915,92 @@ DateDiff {
 }
 
 
+---------- Input ----------
+last_day(to_date('2024-10-22'), week)
+---------- Output ---------
+LAST_DAY(to_date('2024-10-22'), WEEK)
+---------- AST ------------
+LastDay {
+    span: Some(
+        0..37,
+    ),
+    unit: Week,
+    date: FunctionCall {
+        span: Some(
+            9..30,
+        ),
+        func: FunctionCall {
+            distinct: false,
+            name: Identifier {
+                span: Some(
+                    9..16,
+                ),
+                name: "to_date",
+                quote: None,
+                ident_type: None,
+            },
+            args: [
+                Literal {
+                    span: Some(
+                        17..29,
+                    ),
+                    value: String(
+                        "2024-10-22",
+                    ),
+                },
+            ],
+            params: [],
+            order_by: [],
+            window: None,
+            lambda: None,
+        },
+    },
+}
+
+
+---------- Input ----------
+last_day(to_date('2024-10-22'))
+---------- Output ---------
+LAST_DAY(to_date('2024-10-22'), MONTH)
+---------- AST ------------
+LastDay {
+    span: Some(
+        0..31,
+    ),
+    unit: Month,
+    date: FunctionCall {
+        span: Some(
+            9..30,
+        ),
+        func: FunctionCall {
+            distinct: false,
+            name: Identifier {
+                span: Some(
+                    9..16,
+                ),
+                name: "to_date",
+                quote: None,
+                ident_type: None,
+            },
+            args: [
+                Literal {
+                    span: Some(
+                        17..29,
+                    ),
+                    value: String(
+                        "2024-10-22",
+                    ),
+                },
+            ],
+            params: [],
+            order_by: [],
+            window: None,
+            lambda: None,
+        },
+    },
+}
+
+
 ---------- Input ----------
 date_sub(QUARTER, 1, to_date('2018-01-02'))
 ---------- Output ---------

tests/sqllogictests/suites/query/functions/02_0012_function_datetimes_tz.test

@@ -36,6 +36,11 @@ select last_day(to_date('2024-02-01'), month);
 ----
 2024-02-29
 
+query B
+select last_day(to_date('2024-02-01'), month)=last_day(to_date('2024-02-01'));
+----
+1
+
 query T
 select last_day(to_date('2024-02-01'), quarter);
 ----