Skip to content

Commit 3acf8ea

Browse files
authored
chore(query): add encoding/decoding size in task client (#17965)
* chore(query): add encoding/decoding size in task client * update * update * remove macos
1 parent 668b9b7 commit 3acf8ea

File tree

3 files changed

+32
-24
lines changed

3 files changed

+32
-24
lines changed

.github/workflows/bindings.python.yml

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -43,27 +43,27 @@ jobs:
4343
name: python-linux-${{ matrix.arch }}
4444
path: src/bendpy/dist/*.whl
4545

46-
macos:
47-
if: inputs.tag
48-
runs-on: macos-latest
49-
strategy:
50-
matrix:
51-
arch:
52-
- aarch64
53-
steps:
54-
- uses: actions/checkout@v4
55-
with:
56-
fetch-depth: 0
57-
- uses: ./.github/actions/build_bindings_python
58-
with:
59-
target: ${{ matrix.arch }}-apple-darwin
60-
version: ${{ inputs.tag }}
61-
- name: upload
62-
if: inputs.tag
63-
uses: actions/upload-artifact@v4
64-
with:
65-
name: python-macos-${{ matrix.arch }}
66-
path: src/bendpy/dist/*.whl
46+
# macos:
47+
# if: inputs.tag
48+
# runs-on: macos-latest
49+
# strategy:
50+
# matrix:
51+
# arch:
52+
# - aarch64
53+
# steps:
54+
# - uses: actions/checkout@v4
55+
# with:
56+
# fetch-depth: 0
57+
# - uses: ./.github/actions/build_bindings_python
58+
# with:
59+
# target: ${{ matrix.arch }}-apple-darwin
60+
# version: ${{ inputs.tag }}
61+
# - name: upload
62+
# if: inputs.tag
63+
# uses: actions/upload-artifact@v4
64+
# with:
65+
# name: python-macos-${{ matrix.arch }}
66+
# path: src/bendpy/dist/*.whl
6767

6868
publish:
6969
if: inputs.tag

scripts/setup/dev_setup.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -656,8 +656,8 @@ if [[ "$INSTALL_BUILD_TOOLS" == "true" ]]; then
656656

657657
# Any call to cargo will make rustup install the correct toolchain
658658
cargo version
659-
cargo install cargo-quickinstall
660-
cargo quickinstall cargo-binstall
659+
## install cargo-binstall
660+
curl -L --proto '=https' --tlsv1.2 -sSf https://raw.githubusercontent.com/cargo-bins/cargo-binstall/main/install-from-binstall-release.sh | bash
661661
cargo binstall -y sccache
662662
cargo binstall -y cargo-zigbuild
663663
cargo binstall -y cargo-nextest

src/common/cloud_control/src/task_client.rs

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,11 @@ use crate::pb::ShowTasksResponse;
3636

3737
pub(crate) const TASK_CLIENT_VERSION: &str = "v1";
3838
pub(crate) const TASK_CLIENT_VERSION_NAME: &str = "TASK_CLIENT_VERSION";
39+
/// Grpc default configuration.
40+
/// The hard limit of maximum message size the client or server can **send**.
41+
pub const MAX_ENCODING_SIZE: usize = 32 * 1024 * 1024;
42+
/// The hard limit of maximum message size the client or server can **receive**.
43+
pub const MAX_DECODING_SIZE: usize = 32 * 1024 * 1024;
3944

4045
pub struct TaskClient {
4146
pub task_client: TaskServiceClient<Channel>,
@@ -44,7 +49,10 @@ pub struct TaskClient {
4449
impl TaskClient {
4550
// TODO: add auth interceptor
4651
pub async fn new(channel: Channel) -> Result<Arc<TaskClient>> {
47-
let task_client = TaskServiceClient::new(channel);
52+
let task_client = TaskServiceClient::new(channel)
53+
.max_decoding_message_size(MAX_DECODING_SIZE)
54+
.max_encoding_message_size(MAX_ENCODING_SIZE);
55+
4856
Ok(Arc::new(TaskClient { task_client }))
4957
}
5058

0 commit comments

Comments
 (0)