Skip to content

Commit 40136f2

Browse files
authored
chore: remove unused ClientLastResps (#18383)
1 parent f58ace5 commit 40136f2

File tree

5 files changed

+1
-56
lines changed

5 files changed

+1
-56
lines changed

src/meta/process/src/kv_processor.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,6 @@ where F: Fn(&str, Vec<u8>) -> Result<Vec<u8>, anyhow::Error>
107107
RaftStoreEntry::RaftStateKV { .. } => Ok(None),
108108
RaftStoreEntry::Expire { .. } => Ok(None),
109109
RaftStoreEntry::Sequences { .. } => Ok(None),
110-
RaftStoreEntry::ClientLastResps { .. } => Ok(None),
111110
RaftStoreEntry::LogMeta { .. } => Ok(None),
112111

113112
RaftStoreEntry::NodeId(_) => Ok(None),

src/meta/raft-store/src/key_spaces.rs

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ use crate::ondisk::Header;
3535
use crate::ondisk::OnDisk;
3636
use crate::state::RaftStateKey;
3737
use crate::state::RaftStateValue;
38-
use crate::state_machine::ClientLastRespValue;
3938
use crate::state_machine::ExpireKey;
4039
use crate::state_machine::ExpireValue;
4140
use crate::state_machine::LogMetaKey;
@@ -118,13 +117,7 @@ impl SledKeySpace for Sequences {
118117
type V = SeqNum;
119118
}
120119

121-
pub struct ClientLastResps {}
122-
impl SledKeySpace for ClientLastResps {
123-
const PREFIX: u8 = 10;
124-
const NAME: &'static str = "client-last-resp";
125-
type K = String;
126-
type V = ClientLastRespValue;
127-
}
120+
// Reserved: removed: `pub struct ClientLastResps {}`, PREFIX = 10;
128121

129122
pub struct DataHeader {}
130123
impl SledKeySpace for DataHeader {
@@ -242,7 +235,6 @@ pub enum RaftStoreEntry {
242235
Expire { key: <Expire as SledKeySpace>::K, value: <Expire as SledKeySpace>::V, },
243236
GenericKV { key: <GenericKV as SledKeySpace>::K, value: <GenericKV as SledKeySpace>::V, },
244237
Sequences { key: <Sequences as SledKeySpace>::K, value: <Sequences as SledKeySpace>::V, },
245-
ClientLastResps { key: <ClientLastResps as SledKeySpace>::K, value: <ClientLastResps as SledKeySpace>::V, },
246238
// V003 only
247239
LogMeta { key: <LogMeta as SledKeySpace>::K, value: <LogMeta as SledKeySpace>::V, },
248240

@@ -273,7 +265,6 @@ impl RaftStoreEntry {
273265
| RaftStoreEntry::Expire { .. }
274266
| RaftStoreEntry::GenericKV { .. }
275267
| RaftStoreEntry::Sequences { .. }
276-
| RaftStoreEntry::ClientLastResps { .. }
277268
| RaftStoreEntry::LogEntry(_)
278269
| RaftStoreEntry::NodeId(_)
279270
| RaftStoreEntry::Vote(_)
@@ -295,7 +286,6 @@ impl RaftStoreEntry {
295286
Self::Expire { key, value } => serialize_for_sled!(Expire, key, value),
296287
Self::GenericKV { key, value } => serialize_for_sled!(GenericKV, key, value),
297288
Self::Sequences { key, value } => serialize_for_sled!(Sequences, key, value),
298-
Self::ClientLastResps { key, value } => serialize_for_sled!(ClientLastResps, key, value),
299289
Self::LogMeta { key, value } => serialize_for_sled!(LogMeta, key, value),
300290

301291
RaftStoreEntry::LogEntry(_) |
@@ -329,7 +319,6 @@ impl RaftStoreEntry {
329319
Expire,
330320
GenericKV,
331321
Sequences,
332-
ClientLastResps,
333322
LogMeta
334323
);
335324

@@ -359,7 +348,6 @@ impl TryInto<SMEntry> for RaftStoreEntry {
359348

360349
Self::Logs { .. } => {Err("SMEntry does not contain Logs".to_string())},
361350
Self::RaftStateKV { .. } => {Err("SMEntry does not contain RaftStateKV".to_string())}
362-
Self::ClientLastResps { .. } => {Err("SMEntry does not contain ClientLastResps".to_string())}
363351
Self::LogMeta { .. } => {Err("SMEntry does not contain LogMeta".to_string())}
364352

365353

src/meta/raft-store/src/raft_log_v004/importer.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,9 +109,6 @@ impl Importer {
109109
RaftStoreEntry::Sequences { .. } => {
110110
unreachable!("Sequences should be written to log");
111111
}
112-
RaftStoreEntry::ClientLastResps { .. } => {
113-
unreachable!("ClientLastResps should be written to log");
114-
}
115112
}
116113

117114
Ok(())

src/meta/raft-store/src/state_machine/client_last_resp.rs

Lines changed: 0 additions & 37 deletions
This file was deleted.

src/meta/raft-store/src/state_machine/mod.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
pub use client_last_resp::ClientLastRespValue;
1615
pub use expire::ExpireKey;
1716
pub use expire::ExpireValue;
1817
pub use log_meta::LogMetaKey;
@@ -22,7 +21,6 @@ pub use state_machine_meta::StateMachineMetaKey;
2221
pub use state_machine_meta::StateMachineMetaValue;
2322
pub use user_key::UserKey;
2423

25-
pub mod client_last_resp;
2624
mod expire;
2725
pub mod log_meta;
2826
mod snapshot_id;

0 commit comments

Comments
 (0)