fix: Replace unsafe unwrap() calls with proper error handling in inte… (#18418)

fix: Replace unsafe unwrap() calls with proper error handling in interpreter_set.rs

This commit fixes potential panic issues by replacing two unsafe unwrap() calls:
1. scalar.as_string().unwrap() - Now returns a proper error if the scalar is not a string
2. c.index(0).unwrap() - Now returns an Internal error if accessing the first row fails

These changes improve the robustness of the SET statement interpreter by providing
meaningful error messages instead of panicking, which is crucial for production systems.

Author: Mirza-Samad-Ahmed-Baig

src/query/service/src/interpreters/interpreter_set.rs

@@ -70,7 +70,12 @@ impl SetInterpreter {
         let mut is_globals = vec![];
 
         for (var, scalar) in self.set.idents.iter().zip(scalars.into_iter()) {
-            let scalar = scalar.as_string().unwrap();
+            let scalar = scalar.as_string().ok_or_else(|| {
+                ErrorCode::BadArguments(format!(
+                    "Expected string value for setting '{}', but got {:?}",
+                    var, scalar
+                ))
+            })?;
             let ok = match var.to_lowercase().as_str() {
                 // To be compatible with some drivers
                 "sql_mode" | "autocommit" => false,
@@ -216,8 +221,16 @@ impl Interpreter for SetInterpreter {
                 datablock
                     .columns()
                     .iter()
-                    .map(|c| c.index(0).unwrap().to_owned())
-                    .collect()
+                    .map(|c| {
+                        c.index(0)
+                            .ok_or_else(|| {
+                                ErrorCode::Internal(
+                                    "Failed to access first row of datablock column".to_string(),
+                                )
+                            })
+                            .map(|s| s.to_owned())
+                    })
+                    .collect::<Result<Vec<_>>>()?
             }
         };