Skip to content

Commit 585c9b2

Browse files
dantengskyzhaoboran
authored andcommitted
fix: revert arrow converters
1 parent 485aa61 commit 585c9b2

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

src/query/expression/src/converts/arrow/from.rs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,10 +127,7 @@ impl TryFrom<&Field> for TableField {
127127
ArrowDataType::Decimal128(precision, scale) if *scale >= 0 => {
128128
let size = DecimalSize::new(*precision, *scale as _)?;
129129
match size.data_kind() {
130-
DecimalDataKind::Decimal64 => {
131-
TableDataType::Decimal(DecimalDataType::Decimal64(size))
132-
}
133-
DecimalDataKind::Decimal128 => {
130+
DecimalDataKind::Decimal64 | DecimalDataKind::Decimal128 => {
134131
TableDataType::Decimal(DecimalDataType::Decimal128(size))
135132
}
136133
_ => unreachable!(),

src/query/expression/src/converts/arrow/to.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,6 @@ impl From<&TableField> for Field {
114114
TableDataType::Number(ty) => with_number_type!(|TYPE| match ty {
115115
NumberDataType::TYPE => ArrowDataType::TYPE,
116116
}),
117-
// TODO Map DecimalDataType::Decimal64 to ArrowDataType::Decimal64?
118117
TableDataType::Decimal(
119118
DecimalDataType::Decimal64(size) | DecimalDataType::Decimal128(size),
120119
) => ArrowDataType::Decimal128(size.precision(), size.scale() as i8),

0 commit comments

Comments
 (0)