refactor(query): introduces trait SimpleType to simplify the ValueType implementation. (#17909)

Author: forsaken628

src/common/native/src/compression/binary/dict.rs

@@ -77,7 +77,7 @@ impl BinaryCompression for Dict {
         // dict data use custom encoding
         let mut write_options = write_options.clone();
         write_options.forbidden_compressions.push(Compression::Dict);
-        compress_integer(&indices, stats.validity.clone(), write_options, output_buf)?;
+        compress_integer(&indices, stats.validity.clone(), &write_options, output_buf)?;
 
         // data page use plain encoding
         let sets = encoder.get_sets();

src/common/native/src/compression/boolean/mod.rs

@@ -34,11 +34,11 @@ pub fn compress_boolean(
     col: &Bitmap,
     validity: Option<Bitmap>,
     buf: &mut Vec<u8>,
-    write_options: WriteOptions,
+    write_options: &WriteOptions,
 ) -> Result<()> {
     // choose compressor
     let stats = gen_stats(col, validity.clone());
-    let compressor = choose_compressor(col, &stats, &write_options);
+    let compressor = choose_compressor(col, &stats, write_options);
 
     log::debug!(
         "choose boolean compression : {:?}",

src/common/native/src/compression/double/dict.rs

@@ -60,7 +60,7 @@ impl<T: DoubleType> DoubleCompression<T> for Dict {
         // dict data use custom encoding
         let mut write_options = write_options.clone();
         write_options.forbidden_compressions.push(Compression::Dict);
-        compress_integer(&indices, stats.validity.clone(), write_options, output_buf)?;
+        compress_integer(&indices, stats.validity.clone(), &write_options, output_buf)?;
 
         let sets = encoder.get_sets();
         output_buf.extend_from_slice(&(sets.len() as u32).to_le_bytes());

src/common/native/src/compression/double/freq.rs

@@ -80,7 +80,7 @@ impl<T: DoubleType> DoubleCompression<T> for Freq {
         write_options.forbidden_compressions.push(Compression::Freq);
 
         let exceptions = exceptions.into();
-        compress_double(&exceptions, stats.validity.clone(), write_options, output)?;
+        compress_double(&exceptions, stats.validity.clone(), &write_options, output)?;
 
         Ok(output.len() - size)
     }

src/common/native/src/compression/double/mod.rs

@@ -45,12 +45,12 @@ use crate::write::WriteOptions;
 pub fn compress_double<T: DoubleType>(
     col: &Buffer<T>,
     validity: Option<Bitmap>,
-    write_options: WriteOptions,
+    write_options: &WriteOptions,
     buf: &mut Vec<u8>,
 ) -> Result<()> {
     // choose compressor
     let stats = gen_stats(col, validity);
-    let compressor = choose_compressor(col, &stats, &write_options);
+    let compressor = choose_compressor(col, &stats, write_options);
 
     log::debug!(
         "choose double compression : {:?}",
@@ -67,7 +67,7 @@ pub fn compress_double<T: DoubleType>(
             let input_buf = bytemuck::cast_slice(col.as_slice());
             c.compress(input_buf, buf)
         }
-        DoubleCompressor::Extend(c) => c.compress(col, &stats, &write_options, buf),
+        DoubleCompressor::Extend(c) => c.compress(col, &stats, write_options, buf),
     }?;
     buf[pos..pos + 4].copy_from_slice(&(compressed_size as u32).to_le_bytes());
     buf[pos + 4..pos + 8]

src/common/native/src/compression/integer/dict.rs

@@ -59,7 +59,7 @@ impl<T: IntegerType> IntegerCompression<T> for Dict {
         // dict data use custom encoding
         let mut write_options = write_options.clone();
         write_options.forbidden_compressions.push(Compression::Dict);
-        compress_integer(&indices, stats.validity.clone(), write_options, output_buf)?;
+        compress_integer(&indices, stats.validity.clone(), &write_options, output_buf)?;
 
         let sets = encoder.get_sets();
         output_buf.extend_from_slice(&(sets.len() as u32).to_le_bytes());

src/common/native/src/compression/integer/freq.rs

@@ -83,7 +83,7 @@ impl<T: IntegerType> IntegerCompression<T> for Freq {
         write_options.forbidden_compressions.push(Compression::Freq);
 
         let exceptions = exceptions.into();
-        compress_integer(&exceptions, stats.validity.clone(), write_options, output)?;
+        compress_integer(&exceptions, stats.validity.clone(), &write_options, output)?;
 
         Ok(output.len() - size)
     }

src/common/native/src/compression/integer/mod.rs

@@ -48,12 +48,12 @@ use crate::write::WriteOptions;
 pub fn compress_integer<T: IntegerType>(
     col: &Buffer<T>,
     validity: Option<Bitmap>,
-    write_options: WriteOptions,
+    write_options: &WriteOptions,
     buf: &mut Vec<u8>,
 ) -> Result<()> {
     // choose compressor
     let stats = gen_stats(col, validity);
-    let compressor = choose_compressor(col, &stats, &write_options);
+    let compressor = choose_compressor(col, &stats, write_options);
 
     log::debug!(
         "choose integer compression : {:?}",
@@ -76,7 +76,7 @@ pub fn compress_integer<T: IntegerType>(
                     "Not support Extend compressor".to_string(),
                 ));
             }
-            c.compress(col, &stats, &write_options, buf)
+            c.compress(col, &stats, write_options, buf)
         }
     }?;
     buf[pos..pos + 4].copy_from_slice(&(compressed_size as u32).to_le_bytes());

src/common/native/src/compression/view/mod.rs

@@ -25,12 +25,12 @@ pub fn compress_view(
     col: &BinaryViewColumn,
     validity: Option<Bitmap>,
     buf: &mut Vec<u8>,
-    write_options: WriteOptions,
+    write_options: &WriteOptions,
 ) -> Result<()> {
     // choose compressor
     let col = col.gc_with_dict(validity.clone());
     let view_array: Buffer<i128> = col.views().iter().map(|x| x.as_i128()).collect();
-    compress_integer(&view_array, validity, write_options.clone(), buf)?;
+    compress_integer(&view_array, validity, write_options, buf)?;
     compress_buffers(&col, buf, write_options.default_compression)
 }
 

src/common/native/src/write/boolean.rs

@@ -24,7 +24,7 @@ pub(crate) fn write_bitmap<W: Write>(
     w: &mut W,
     column: &Bitmap,
     validity: Option<Bitmap>,
-    write_options: WriteOptions,
+    write_options: &WriteOptions,
     scratch: &mut Vec<u8>,
 ) -> Result<()> {
     scratch.clear();