fix(query): fix find_leveled_eq_filters works with not in (#18334)

* fix(query): fix find_leveled_eq_filters works with not in

* fix(query): fix find_leveled_eq_filters works with not in

* fix(query): fix find_leveled_eq_filters works with not in

Author: sundy-li

src/query/expression/src/utils/filter_helper.rs

@@ -63,42 +63,50 @@ impl FilterHelpers {
             values.dedup();
 
             let mut results = Vec::with_capacity(values.len());
+            let mut invalid_results = Vec::with_capacity(values.len());
 
             if !values.is_empty() {
                 for value in values.iter() {
-                    // replace eq with false
-                    let expr =
-                        expr.replace_function_literals("eq", &mut |col_name, scalar, func| {
-                            if col_name.name() == *name {
-                                if scalar == value {
-                                    let data_type = func.function.signature.return_type.clone();
-                                    Some(Expr::Constant(Constant {
-                                        span: None,
-                                        scalar: Scalar::Boolean(false),
-                                        data_type,
-                                    }))
+                    // replace eq with false, true
+                    for (idx, t) in [false, true].iter().enumerate() {
+                        let expr =
+                            expr.replace_function_literals("eq", &mut |col_name, scalar, func| {
+                                if col_name.name() == *name {
+                                    if scalar == value {
+                                        let data_type = func.function.signature.return_type.clone();
+                                        Some(Expr::Constant(Constant {
+                                            span: None,
+                                            scalar: Scalar::Boolean(*t),
+                                            data_type,
+                                        }))
+                                    } else {
+                                        // for other values, we just ignore it
+                                        None
+                                    }
                                 } else {
-                                    // for other values, we just ignore it
+                                    // for other columns, we just ignore it
                                     None
                                 }
-                            } else {
-                                // for other columns, we just ignore it
-                                None
-                            }
-                        });
+                            });
 
-                    let (folded_expr, _) = ConstantFolder::fold(&expr, func_ctx, fn_registry);
+                        let (folded_expr, _) = ConstantFolder::fold(&expr, func_ctx, fn_registry);
 
-                    if let Expr::Constant(Constant {
-                        scalar: Scalar::Boolean(false),
-                        ..
-                    }) = folded_expr
-                    {
-                        results.push(value.clone());
+                        if let Expr::Constant(Constant {
+                            scalar: Scalar::Boolean(false),
+                            ..
+                        }) = folded_expr
+                        {
+                            if idx == 0 {
+                                results.push(value.clone());
+                            } else {
+                                // may contains negative values
+                                invalid_results.push(value.clone());
+                            }
+                        }
                     }
                 }
 
-                // let's check if it contains or for other columns
+                values.retain(|v| !invalid_results.contains(v));
                 if results.is_empty() && !values.is_empty() {
                     let mut results_all_used = true;
                     // let's check or function that
@@ -117,6 +125,7 @@ impl FilterHelpers {
                             }
                         }
                     });
+
                     if results_all_used {
                         results = values;
                     }

src/query/functions/tests/it/type_check.rs

@@ -220,6 +220,21 @@ fn test_find_leveled_eq_filters() {
             ],
             vec![],
         ),
+
+        (
+            "not (database = 'default')",
+            vec![],
+            vec![],
+            vec![],
+        ),
+
+
+        (
+            "not (database = 'default' or database = 'abcd')",
+            vec![],
+            vec![],
+            vec![],
+        ),
     ];
 
     let cols = vec![

tests/sqllogictests/suites/base/01_system/01_0001_system_tables.test

@@ -50,6 +50,16 @@ t b
 t c
 t100 c
 
+query T
+select count() > 0 from system.tables where database not in ('system', 'default');
+----
+1
+
+query T
+select count() > 0 from system.tables where database not in ('default');
+----
+1
+
 query T
 select name, database from system.tables where database='c' or name ='t' or name like 't10%' order by name, database;
 ----