chore: Extracting databend_common_version to help improve compilation cache hit rate (#17801)

Before refactoring, compilation time was around 19 minutes, with 88 Cache misses.
After refactoring the compile time is around 16 minutes with 72 Cache misses

Author: forsaken628

.github/actions/build_linux/action.yml

@@ -90,6 +90,7 @@ runs:
     - name: Check Binary Info
       shell: bash
       run: |
+        grep ' Compiled in ' target/sccache.log
         readelf -p .comment ./target/${{ inputs.target }}/${{ env.BUILD_PROFILE }}/databend-query || true
         ldd ./target/${{ inputs.target }}/${{ env.BUILD_PROFILE }}/databend-query || true
 

.github/actions/test_unit/action.yml

@@ -12,6 +12,7 @@ runs:
     - shell: bash
       run: |
         cargo -Zgitoxide=fetch -Zgit=shallow-index,shallow-deps nextest run --no-fail-fast --hide-progress-bar
+        grep ' Compiled in ' target/sccache.log
       env:
         RUST_TEST_THREADS: "8"
         RUST_LOG: ERROR

Cargo.lock

@@ -28,6 +28,7 @@ members = [
     "src/common/storage",
     "src/common/vector",
     "src/common/license",
+    "src/common/version",
     "src/query/ast",
     "src/query/codegen",
     "src/query/config",
@@ -187,6 +188,7 @@ databend-common-storages-view = { path = "src/query/storages/view" }
 databend-common-tracing = { path = "src/common/tracing" }
 databend-common-users = { path = "src/query/users" }
 databend-common-vector = { path = "src/common/vector" }
+databend-common-version = { path = "src/common/version" }
 databend-enterprise-aggregating-index = { path = "src/query/ee_features/aggregating_index" }
 databend-enterprise-attach-table = { path = "src/query/ee_features/attach_table" }
 databend-enterprise-data-mask-feature = { path = "src/query/ee_features/data_mask" }

Cargo.toml

@@ -73,7 +73,7 @@ if [[ $ENABLE_SCCACHE == "true" ]]; then
 	env | grep -E "^SCCACHE_" >"${CARGO_HOME}/sccache.env"
 	EXTRA_ARGS="${EXTRA_ARGS} --env RUSTC_WRAPPER=sccache --env-file ${CARGO_HOME}/sccache.env"
 	if [[ $COMMAND == "cargo" ]]; then
-		COMMAND_ARGS="mold -run ${COMMAND_ARGS} && sccache --show-stats"
+		COMMAND_ARGS="mold -run ${COMMAND_ARGS} && sccache --show-adv-stats"
 	fi
 fi
 

scripts/setup/run_build_tool.sh

@@ -30,6 +30,7 @@ databend-common-meta-client = { workspace = true }
 databend-common-metrics = { workspace = true }
 databend-common-storage = { workspace = true }
 databend-common-tracing = { workspace = true }
+databend-common-version = { workspace = true }
 databend-enterprise-query = { workspace = true }
 databend-query = { workspace = true }
 databend-storages-common-table-meta = { workspace = true }

src/binaries/Cargo.toml

@@ -26,6 +26,7 @@ use databend_common_exception::ResultExt;
 use databend_common_tracing::pipe_file;
 use databend_common_tracing::set_crash_hook;
 use databend_common_tracing::SignalListener;
+use databend_common_version::DATABEND_COMMIT_VERSION;
 use databend_enterprise_query::enterprise_services::EnterpriseServices;
 use entry::MainError;
 
@@ -37,12 +38,10 @@ use crate::entry::start_services;
 pub static GLOBAL_ALLOCATOR: TrackingGlobalAllocator = TrackingGlobalAllocator::create();
 
 fn main() {
-    let binary_version = (*databend_common_config::DATABEND_COMMIT_VERSION).clone();
-
     // Crash tracker
     let (input, output) = pipe_file().unwrap();
     set_crash_hook(output);
-    SignalListener::spawn(input, binary_version);
+    SignalListener::spawn(input, DATABEND_COMMIT_VERSION.to_string());
 
     // Thread tracker
     ThreadTracker::init();

src/binaries/query/ee_main.rs

@@ -20,17 +20,17 @@ use databend_common_base::runtime::set_alloc_error_hook;
 use databend_common_base::runtime::GLOBAL_MEM_STAT;
 use databend_common_config::Commands;
 use databend_common_config::InnerConfig;
-use databend_common_config::DATABEND_COMMIT_VERSION;
-use databend_common_config::DATABEND_GIT_SEMVER;
-use databend_common_config::DATABEND_GIT_SHA;
-use databend_common_config::DATABEND_SEMVER;
 use databend_common_exception::ErrorCode;
 use databend_common_exception::Result;
 use databend_common_exception::ResultExt;
 use databend_common_meta_client::MIN_METASRV_SEMVER;
 use databend_common_metrics::system::set_system_version;
 use databend_common_storage::DataOperator;
 use databend_common_tracing::set_panic_hook;
+use databend_common_version::DATABEND_COMMIT_VERSION;
+use databend_common_version::DATABEND_GIT_SEMVER;
+use databend_common_version::DATABEND_GIT_SHA;
+use databend_common_version::DATABEND_SEMVER;
 use databend_query::clusters::ClusterDiscovery;
 use databend_query::local;
 use databend_query::persistent_log::GlobalPersistentLog;
@@ -220,7 +220,7 @@ pub async fn start_services(conf: &InnerConfig) -> Result<(), MainError> {
     {
         set_system_version(
             "query",
-            DATABEND_GIT_SEMVER.as_str(),
+            DATABEND_GIT_SEMVER.unwrap_or("unknown"),
             DATABEND_GIT_SHA.as_str(),
         );
         let address = conf.query.metric_api_address.clone();

src/binaries/query/entry.rs

@@ -28,6 +28,7 @@ use databend_common_license::license_manager::OssLicenseManager;
 use databend_common_tracing::pipe_file;
 use databend_common_tracing::set_crash_hook;
 use databend_common_tracing::SignalListener;
+use databend_common_version::DATABEND_COMMIT_VERSION;
 use entry::MainError;
 
 use crate::entry::init_services;
@@ -38,12 +39,10 @@ use crate::entry::start_services;
 pub static GLOBAL_ALLOCATOR: TrackingGlobalAllocator = TrackingGlobalAllocator::create();
 
 fn main() {
-    let binary_version = (*databend_common_config::DATABEND_COMMIT_VERSION).clone();
-
     // Crash tracker
     let (input, output) = pipe_file().unwrap();
     set_crash_hook(output);
-    SignalListener::spawn(input, binary_version);
+    SignalListener::spawn(input, DATABEND_COMMIT_VERSION.to_string());
 
     // Thread tracker
     ThreadTracker::init();

src/binaries/query/oss_main.rs

@@ -24,12 +24,12 @@ use std::io::Write;
 use clap::Parser;
 use databend_common_config::Config;
 use databend_common_config::InnerConfig;
-use databend_common_config::DATABEND_COMMIT_VERSION;
 use databend_common_exception::Result;
 use databend_common_storage::init_operator;
 use databend_common_storage::StorageConfig;
 use databend_common_tracing::init_logging;
 use databend_common_tracing::Config as LogConfig;
+use databend_common_version::DATABEND_COMMIT_VERSION;
 use databend_query::GlobalServices;
 use databend_storages_common_table_meta::meta::SegmentInfo;
 use databend_storages_common_table_meta::meta::TableSnapshot;