Skip to content

Commit 938c51a

Browse files
xiedeyantusundy-li
andauthored
chore(query): update comment in rule_grouping_sets_to_union.rs (#18450)
* [chore] update comment in rule_grouping_sets_to_union.rs * Addressed --------- Co-authored-by: sundyli <[email protected]>
1 parent 8deda8b commit 938c51a

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/query/sql/src/planner/optimizer/optimizers/rule/agg_rules/rule_grouping_sets_to_union.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ use crate::plans::VisitorMut;
4242
use crate::IndexType;
4343
use crate::ScalarExpr;
4444

45-
// TODO
4645
const ID: RuleID = RuleID::GroupingSetsToUnion;
4746
// Split `Grouping Sets` into `Union All` of `Group by`
4847
// Eg:
@@ -52,11 +51,11 @@ const ID: RuleID = RuleID::GroupingSetsToUnion;
5251

5352
// INTO:
5453

55-
// select number % 10 AS a, number % 3 AS b, number % 4 AS c
54+
// select number % 10 AS a, number % 3 AS b, null AS c
5655
// from numbers(100000000)
5756
// group by a,b
5857
// union all
59-
// select number % 10 AS a, number % 3 AS b, number % 4 AS c
58+
// select number % 10 AS a, null AS b, number % 4 AS c
6059
// from numbers(100000000)
6160
// group by a,c
6261
//

0 commit comments

Comments
 (0)