Skip to content

Commit 94d48cf

Browse files
committed
revert string iterator( performance degrades)
1 parent 0da4357 commit 94d48cf

File tree

2 files changed

+160
-506
lines changed

2 files changed

+160
-506
lines changed

src/common/experimental_parquet_reader/src/column/common.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -248,6 +248,7 @@ fn convert_endianness_and_copy<T: Copy>(src_bytes: &[u8], dst_slice: &mut [T]) {
248248
}
249249

250250
/// Perform defensive checks for nullable vs non-nullable columns
251+
#[cfg(debug_assertions)]
251252
pub fn validate_column_nullability(def_levels: &[u8], is_nullable: bool) -> Result<()> {
252253
if is_nullable {
253254
// Nullable columns must have definition levels
@@ -279,6 +280,7 @@ pub fn validate_physical_type(actual: PhysicalType, expected: PhysicalType) -> R
279280
}
280281

281282
/// Validate values buffer alignment
283+
#[cfg(debug_assertions)]
282284
pub fn validate_buffer_alignment<T>(values_buffer: &[u8]) -> Result<()> {
283285
let type_size = std::mem::size_of::<T>();
284286
if values_buffer.len() % type_size != 0 {

0 commit comments

Comments
 (0)