fix: update failed with Unable to get field named... (#18078)

* fix

* add test

Author: SkyFan2002

src/query/sql/src/planner/binder/bind_mutation/mutation_expression.rs

@@ -198,6 +198,18 @@ impl MutationExpression {
                 let (mut s_expr, mut bind_context) =
                     binder.bind_table_reference(bind_context, target)?;
 
+                // Note: We intentionally get target table index before binding source table,
+                // because source table may contain tables with same name as target table,
+                // which could cause us to get wrong table index if we do it later.
+                let target_table_index = binder
+                    .metadata
+                    .read()
+                    .get_table_index(
+                        Some(target_table_identifier.database_name().as_str()),
+                        target_table_identifier.table_name().as_str(),
+                    )
+                    .ok_or_else(|| ErrorCode::Internal("Can't get target table index"))?;
+
                 let from_s_expr = if let Some(from) = from {
                     let (from_s_expr, mut from_context) =
                         binder.bind_table_reference(&mut bind_context, from)?;
@@ -216,16 +228,6 @@ impl MutationExpression {
                     None
                 };
 
-                // Get target table index.
-                let target_table_index = binder
-                    .metadata
-                    .read()
-                    .get_table_index(
-                        Some(target_table_identifier.database_name().as_str()),
-                        target_table_identifier.table_name().as_str(),
-                    )
-                    .ok_or_else(|| ErrorCode::Internal("Can't get target table index"))?;
-
                 // If the filter is a simple expression, change the mutation strategy to MutationStrategy::Direct.
                 let (mut mutation_strategy, predicates) =
                     binder.process_filter(&mut bind_context, filter)?;

tests/sqllogictests/suites/base/09_fuse_engine/09_0049_issue_18073.test

@@ -0,0 +1,27 @@
+statement ok
+CREATE OR REPLACE TABLE students (
+    code VARCHAR, 
+    score INT 
+);
+
+statement ok
+CREATE OR REPLACE TABLE pairs (
+    student1 VARCHAR,  
+    student2 VARCHAR,  
+    score1 INT,        
+    score2 INT         
+);
+
+statement ok
+UPDATE pairs AS p 
+SET p.score1 = data.s1, p.score2 = data.s2 
+FROM (
+    SELECT 
+        split_part(a.code, '_', 2) AS c1, a.score AS s1,
+        split_part(b.code, '_', 2) AS c2, b.score AS s2
+    FROM pairs AS p 
+    JOIN students AS a, students AS b 
+    WHERE split_part(a.code, '_', 2) = p.student1 
+        AND split_part(b.code, '_', 2) = p.student2
+) data  
+WHERE p.student1 = data.c1 AND p.student2 = data.c2;