Skip to content

Commit a4de17b

Browse files
committed
clean up debug code
1 parent 073ec4b commit a4de17b

File tree

5 files changed

+1
-20
lines changed

5 files changed

+1
-20
lines changed

src/query/service/src/interpreters/interpreter_insert.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -485,8 +485,6 @@ impl Interpreter for InsertInterpreter {
485485

486486
let ctx = self.ctx.clone();
487487
let overwrite = self.plan.overwrite;
488-
eprintln!(">>> main piepline {:?}", build_res.main_pipeline);
489-
eprintln!(">>> source piepline {:?}", build_res.sources_pipelines);
490488
build_res.main_pipeline.set_on_finished(move |may_error| {
491489
// capture out variable
492490
let overwrite = overwrite;

src/query/service/src/schedulers/fragments/fragmenter.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,9 +94,7 @@ impl Fragmenter {
9494
}
9595

9696
pub fn build_fragment(mut self, plan: &PhysicalPlan) -> Result<PlanFragment> {
97-
eprintln!("origin plan {:?}", &plan);
9897
let root = self.replace(plan)?;
99-
eprintln!("after replace {:?}", &root);
10098
let mut root_fragment = PlanFragment {
10199
plan: root,
102100
fragment_type: FragmentType::Root,

src/query/storages/fuse/src/io/read/bloom/block_filter_reader.rs

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -82,13 +82,6 @@ async fn load_bloom_filter_by_columns<'a>(
8282
) -> Result<BlockFilter> {
8383
// 1. load index meta
8484
let bloom_index_meta = load_index_meta(dal.clone(), index_path, index_length).await?;
85-
// let file_meta = &bloom_index_meta.0;
86-
// if file_meta.row_groups.len() != 1 {
87-
// return Err(ErrorCode::StorageOther(format!(
88-
// "invalid bloom filter index, number of row group should be 1, but found {} row groups",
89-
// file_meta.row_groups.len()
90-
// )));
91-
//}
9285

9386
// 2. filter out columns that needed and exist in the index
9487
// 2.1 dedup the columns

src/query/storages/fuse/src/io/read/bloom/column_filter_reader.rs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -141,11 +141,6 @@ impl Loader<Xor8Filter> for Xor8FilterLoader {
141141
descriptor: self.column_descriptor.descriptor.clone(),
142142
};
143143

144-
eprintln!(
145-
"column descriptor: {:?}",
146-
self.column_descriptor.descriptor.clone()
147-
);
148-
149144
let page_reader = PageReader::new_with_page_meta(
150145
std::io::Cursor::new(bytes),
151146
page_meta_data,

src/query/storages/fuse/src/io/read/meta/meta_readers.rs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -144,11 +144,8 @@ mod thrift_file_meta_read {
144144
use super::*;
145145

146146
// the following code is copied from crate `parquet2`, with slight modification:
147-
// return a ThriftFileMetaData instead of FileMetaData while reader parquet metadata,
147+
// return a ThriftFileMetaData instead of FileMetaData while reading parquet metadata,
148148
// to avoid unnecessary conversions.
149-
//
150-
// It takes about 18s, to convert one million ThriftFileMetaData objects to parquet::metadata::FileMetaData,
151-
// and the memory usage of FileMetaData is also larger.
152149

153150
const HEADER_SIZE: u64 = PARQUET_MAGIC.len() as u64;
154151
const FOOTER_SIZE: u64 = 8;

0 commit comments

Comments
 (0)