Skip to content

Commit a60af5a

Browse files
authored
chore: fix some meta typo (#18824)
1 parent 6cbbbf7 commit a60af5a

File tree

63 files changed

+124
-96
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

63 files changed

+124
-96
lines changed

.typos.toml

Lines changed: 47 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,39 +1,58 @@
11
# If there are words that you think should not be treated as typo.
22
# Please list here along with a comment.
3+
4+
[default]
5+
extend-ignore-re = [
6+
"(?Rm)^.*(#|//)\\s*typos:disable-line$",
7+
"(#|//)\\s*typos:ignore-next-line\\n.*",
8+
"(?s)(#|//)\\s*typos:off.*?\\n\\s*(#|//)\\s*typos:on",
9+
]
10+
311
[default.extend-words]
412
# Preserved for NdJson
5-
"Nd" = "Nd"
6-
# Microsoft K8s Server
7-
"AKS" = "AKS"
13+
Nd = "Nd"
14+
typ = "typ"
15+
aranges = "aranges"
16+
17+
[default.extend-identifiers]
18+
819
# Wrong cases
9-
"ba" = "ba"
10-
"ue" = "ue"
11-
"INOUT" = "INOUT"
12-
"ser" = "ser"
13-
"Ser" = "Ser"
14-
"flate" = "flate"
15-
"Tke" = "Tke"
16-
"typ" = "typ"
17-
"dows" = "dows"
18-
# created_ons & updated_ons
19-
"ons" = "ons"
20-
21-
# Intentional typos used in SQL error suggestion test cases
22-
"tabl" = "tabl"
23-
"optmize" = "optmize"
24-
"vacum" = "vacum"
25-
"creat" = "creat"
26-
"crate" = "crate"
20+
Tke = "Tke"
21+
ba = "ba"
22+
23+
# sql function name: diff_dows, between_dows
24+
diff_dows = "diff_dows"
25+
between_dows = "between_dows"
26+
27+
into_flate2 = "into_flate2"
2728

2829
[files]
2930
extend-exclude = [
3031
"**/Cargo.toml",
31-
"scripts/benchmark/",
3232
"benchmark/",
33-
"tests/",
34-
"src/meta",
35-
# masked secrets
36-
"src/query/config/src/mask.rs",
37-
# Forked from upstream
38-
"src/common/parquet2"
33+
"tests/sqllogictests",
34+
"tests/nox/java_client/testng.xml",
35+
"tests/data/ddl",
3936
]
37+
38+
# todo: fix me
39+
[type.py]
40+
check-file = false
41+
42+
# todo: fix me
43+
[type.sh]
44+
check-file = false
45+
46+
[type.txt]
47+
check-file = false
48+
49+
[type.sql]
50+
check-file = false
51+
52+
[type.csr]
53+
extend-glob = ["*.csr"]
54+
check-file = false
55+
56+
[type.result]
57+
extend-glob = ["*.result"]
58+
check-file = false

src/common/hashtable/src/utils.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ pub struct MergeIntoBlockInfoIndex {
234234
pub type Interval = (u32, u32);
235235

236236
/// the segment blocks are not sequential,because we do parallel hashtable build.
237-
/// the block lay out in chunks could be like belows:
237+
/// the block lay out in chunks could be like bellows:
238238
/// segment0_block1 |
239239
/// segment1_block0 | chunk0
240240
/// segment0_block0 |

src/common/io/tests/it/main.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,4 +24,4 @@ mod borsh_serialization;
2424
mod cursor_ext;
2525
mod escape;
2626
mod interval;
27-
mod serialization_format_compatability;
27+
mod serialization_format_compatibility;

src/common/io/tests/it/serialization_format_compatability.rs renamed to src/common/io/tests/it/serialization_format_compatibility.rs

File renamed without changes.

src/meta/api/src/garbage_collection_api.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ async fn remove_copied_files_for_dropped_table(
129129
// Loop until:
130130
// - all cleaned
131131
// - or table is removed from meta-service
132-
// - or is no longer in `droppped` state.
132+
// - or is no longer in `dropped` state.
133133
for i in 0..usize::MAX {
134134
let mut txn = TxnRequest::default();
135135

src/meta/api/src/kv_pb_api/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -559,7 +559,7 @@ mod tests {
559559
) -> Result<KVStream<Self::Error>, Self::Error> {
560560
let mut res = Vec::with_capacity(keys.len());
561561
for (i, key) in keys.iter().enumerate() {
562-
// For tesing early return stream.
562+
// For testing early return stream.
563563
if let Some(early_return) = self.early_return {
564564
if i >= early_return {
565565
break;

src/meta/api/src/schema_api_test_suite.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2714,7 +2714,7 @@ impl SchemaApiTestSuite {
27142714
// Change the comment, this modification should not be committed
27152715
req.new_table_meta.comment = "some new comment".to_string();
27162716
// Expects no KV api level error, and no app level error.
2717-
// For the convenience of reviewing, using explict type signature
2717+
// For the convenience of reviewing, using explicit type signature
27182718
let _r: databend_common_meta_app::schema::UpdateTableMetaReply = mt
27192719
.update_multi_table_meta_with_sender(
27202720
UpdateMultiTableMetaReq {
@@ -5526,7 +5526,7 @@ impl SchemaApiTestSuite {
55265526
let handle = runtime.spawn(async move {
55275527
let resp = arc_mt.create_table(create_table_req.clone()).await;
55285528

5529-
// assert that when create table concurrently with corret params return error,
5529+
// assert that when create table concurrently with correct params return error,
55305530
// the error MUST be TxnRetryMaxTimes
55315531
if resp.is_err() {
55325532
assert!(matches!(
@@ -5547,7 +5547,7 @@ impl SchemaApiTestSuite {
55475547
};
55485548
let resp = arc_mt.commit_table_meta(commit_table_req).await;
55495549

5550-
// assert that when commit_table_meta concurrently with corret params return error,
5550+
// assert that when commit_table_meta concurrently with correct params return error,
55515551
// the error MUST be TxnRetryMaxTimes or CommitTableMetaError(prev table id has been changed)
55525552
if resp.is_err() {
55535553
assert!(

src/meta/app/src/principal/procedure.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ impl Display for ProcedureMeta {
7171
fn fmt(&self, f: &mut Formatter) -> fmt::Result {
7272
write!(
7373
f,
74-
"Lanuage: {:?}, args {} return_type: {}, CreatedOn: {:?}, Script: {}, Comment: {:?}",
74+
"Language: {:?}, args {} return_type: {}, CreatedOn: {:?}, Script: {}, Comment: {:?}",
7575
self.procedure_language,
7676
self.arg_names.display_n(1000),
7777
self.return_types.display_n(1000),

src/meta/app/src/schema/table/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ pub struct TableStatistics {
137137
pub number_of_blocks: Option<u64>,
138138
}
139139

140-
/// Iceberg table parition
140+
/// Iceberg table partition
141141
#[derive(serde::Serialize, serde::Deserialize, Clone, Debug, Eq, PartialEq)]
142142
pub enum TablePartition {
143143
Identity { columns: Vec<String> },

src/meta/client/src/grpc_client.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,7 @@ impl MetaGrpcClient {
440440
resp_err: Option<&(dyn std::error::Error + 'static)>,
441441
) {
442442
// TODO: this current endpoint is not stable, may be modified by other thread.
443-
// The caller should pasing the in use endpoint.
443+
// The caller should passing the in use endpoint.
444444
let current_endpoint = self.get_current_endpoint();
445445

446446
let Some(endpoint) = current_endpoint else {

0 commit comments

Comments
 (0)