fix(query): report error when set unknwon setting (#10860)

Author: zhang2014

src/query/settings/src/settings.rs

@@ -94,14 +94,19 @@ impl Settings {
     }
 
     pub fn set_setting(&self, k: String, v: String) -> Result<()> {
-        if let (key, Some(value)) = DefaultSettings::convert_value(k, v)? {
+        if let (key, Some(value)) = DefaultSettings::convert_value(k.clone(), v)? {
             self.changes.insert(key, ChangeValue {
                 value,
                 level: ScopeLevel::Session,
             });
+
+            return Ok(());
         }
 
-        Ok(())
+        Err(ErrorCode::UnknownVariable(format!(
+            "Unknown variable: {:?}",
+            k
+        )))
     }
 
     pub fn set_batch_settings(&self, settings: &HashMap<String, String>) -> Result<()> {

src/query/settings/src/settings_global.rs

@@ -54,7 +54,7 @@ impl Settings {
     }
 
     pub async fn set_global_setting(&self, k: String, v: String) -> Result<()> {
-        if let (key, Some(value)) = DefaultSettings::convert_value(k, v)? {
+        if let (key, Some(value)) = DefaultSettings::convert_value(k.clone(), v)? {
             self.changes.insert(key.clone(), ChangeValue {
                 value: value.clone(),
                 level: ScopeLevel::Global,
@@ -63,9 +63,14 @@ impl Settings {
             UserApiProvider::instance()
                 .set_setting(&self.tenant, UserSetting { name: key, value })
                 .await?;
+
+            return Ok(());
         }
 
-        Ok(())
+        Err(ErrorCode::UnknownVariable(format!(
+            "Unknown variable: {:?}",
+            k
+        )))
     }
 
     pub async fn load_global_changes(&self) -> Result<()> {

tests/sqllogictests/suites/base/20+_others/20_0015_set_unknown_setting

@@ -0,0 +1,5 @@
+statement error 2801
+SET xxxx = 'xxxx';
+
+statement error 2801
+SET GLOBAL xxxx = 'xxxx';