Skip to content

Commit a8c0855

Browse files
committed
chore(query): Set the default value of enable_experimental_virtual_column as true
1 parent a332371 commit a8c0855

File tree

6 files changed

+4
-30
lines changed

6 files changed

+4
-30
lines changed

src/query/ee/tests/it/storages/fuse/operations/virtual_columns.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,6 @@ async fn test_fuse_do_refresh_virtual_column() -> Result<()> {
3434
.default_session()
3535
.get_settings()
3636
.set_data_retention_time_in_days(0)?;
37-
fixture
38-
.default_session()
39-
.get_settings()
40-
.set_enable_experimental_virtual_column(1)?;
4137
fixture.create_default_database().await?;
4238
fixture.create_variant_table().await?;
4339

src/query/ee/tests/it/storages/fuse/operations/virtual_columns_builder.rs

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,6 @@ use jsonb::OwnedJsonb;
3232
#[tokio::test(flavor = "multi_thread")]
3333
async fn test_virtual_column_builder() -> Result<()> {
3434
let fixture = TestFixture::setup_with_custom(EESetup::new()).await?;
35-
36-
fixture
37-
.default_session()
38-
.get_settings()
39-
.set_enable_experimental_virtual_column(1)?;
4035
fixture.create_default_database().await?;
4136
fixture.create_variant_table().await?;
4237

@@ -316,11 +311,6 @@ async fn test_virtual_column_builder() -> Result<()> {
316311
#[tokio::test(flavor = "multi_thread")]
317312
async fn test_virtual_column_builder_stream_write() -> Result<()> {
318313
let fixture = TestFixture::setup_with_custom(EESetup::new()).await?;
319-
320-
fixture
321-
.default_session()
322-
.get_settings()
323-
.set_enable_experimental_virtual_column(1)?;
324314
fixture.create_default_database().await?;
325315
fixture.create_variant_table().await?;
326316

src/query/settings/src/settings_default.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1404,7 +1404,7 @@ impl DefaultSettings {
14041404
range: Some(SettingRange::Numeric(1..=1024)),
14051405
}),
14061406
("enable_experimental_virtual_column", DefaultSettingValue {
1407-
value: UserSettingValue::UInt64(0),
1407+
value: UserSettingValue::UInt64(1),
14081408
desc: "Enables experimental virtual column",
14091409
mode: SettingMode::Both,
14101410
scope: SettingScope::Both,

tests/sqllogictests/suites/ee/01_ee_system/01_0002_virtual_column.test

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,6 @@ CREATE DATABASE test_virtual_column
2121
statement ok
2222
USE test_virtual_column
2323

24-
statement ok
25-
set enable_experimental_virtual_column = 1;
26-
2724
statement ok
2825
drop table if exists t1
2926

@@ -677,9 +674,6 @@ FROM test_stream;
677674
9 "Richard" 33 "Austin" "hiking" "cycling"
678675
10 "Lisa" 26 "Chicago" "gaming" "reading"
679676

680-
statement ok
681-
set enable_experimental_virtual_column = 0;
682-
683677
statement ok
684678
DROP DATABASE test_virtual_column
685679

tests/sqllogictests/suites/ee/04_ee_inverted_index/04_0000_inverted_index_base.test

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -476,7 +476,7 @@ idx2 INVERTED books(title, author, description)index_record='"basic"' tokenizer=
476476
query TII
477477
select name, index_size, inverted_index_size from system.tables where name='t1' and database='test_inverted_index';
478478
----
479-
t1 2828 2390
479+
t1 5316 2390
480480

481481
query III
482482
select row_count, bloom_filter_size, inverted_index_size from fuse_block('test_inverted_index', 't1')
@@ -486,12 +486,12 @@ select row_count, bloom_filter_size, inverted_index_size from fuse_block('test_i
486486
query IIII
487487
select block_count, row_count, index_size, inverted_index_size from fuse_segment('test_inverted_index', 't1');
488488
----
489-
1 10 2828 2390
489+
1 10 5316 2390
490490

491491
query IIII
492492
select block_count, row_count, index_size, inverted_index_size from fuse_snapshot('test_inverted_index', 't1');
493493
----
494-
1 10 2828 2390
494+
1 10 5316 2390
495495

496496
statement ok
497497
CREATE TABLE t2 (id int, body string)

tests/sqllogictests/suites/mode/standalone/ee/explain_virtual_column.test

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,6 @@ CREATE DATABASE test_virtual_db
2424
statement ok
2525
USE test_virtual_db
2626

27-
statement ok
28-
set enable_experimental_virtual_column = 1;
29-
3027
statement ok
3128
drop table if exists t1
3229

@@ -743,9 +740,6 @@ drop table data_main
743740
statement ok
744741
drop table data_staging
745742

746-
statement ok
747-
set enable_experimental_virtual_column = 0;
748-
749743
statement ok
750744
USE default
751745

0 commit comments

Comments
 (0)