Skip to content

Commit ba92f69

Browse files
authored
fix(storage): disable_credential_loader not been updated while role_arn set (#18115)
Signed-off-by: Xuanwo <[email protected]>
1 parent 40e3d1c commit ba92f69

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

src/meta/app/src/storage/storage_params.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,11 @@ impl StorageParams {
204204
s1.external_id = s2.external_id;
205205
s1.master_key = s2.master_key;
206206
s1.network_config = s2.network_config;
207+
s1.disable_credential_loader = s2.disable_credential_loader;
208+
// Remove disable_credential_loader is role_arn has been set.
209+
if !s1.role_arn.is_empty() {
210+
s1.disable_credential_loader = false;
211+
}
207212
Ok(Self::S3(s1))
208213
}
209214
(s1, s2) => Err(ErrorCode::StorageOther(format!(

0 commit comments

Comments
 (0)