Merge pull request #10662 from sundy-li/sleep

chore(planner): support multi filter pushdown into scan

Author: BohuTANG

src/query/functions/src/scalars/other.rs

@@ -99,28 +99,31 @@ pub fn register(registry: &mut FunctionRegistry) {
         "sleep",
         FunctionProperty::default(),
         |_| FunctionDomain::MayThrow,
-        vectorize_with_builder_1_arg::<Float64Type, UInt8Type>(move |val, output, ctx| {
-            let duration = Duration::try_from_secs_f64(val.into()).map_err(|x| x.to_string());
-            match duration {
-                Ok(duration) => {
-                    if duration.gt(&Duration::from_secs(300)) {
-                        let err = format!(
-                            "The maximum sleep time is 300 seconds. Requested: {:?}",
-                            duration
-                        );
-                        ctx.set_error(output.len(), err);
-                        output.push(0);
-                    } else {
-                        std::thread::sleep(duration);
-                        output.push(1);
+        |a, ctx| {
+            if let Some(val) = a.as_scalar() {
+                let duration =
+                    Duration::try_from_secs_f64((*val).into()).map_err(|x| x.to_string());
+                match duration {
+                    Ok(duration) => {
+                        if duration.gt(&Duration::from_secs(300)) {
+                            let err = format!(
+                                "The maximum sleep time is 300 seconds. Requested: {:?}",
+                                duration
+                            );
+                            ctx.set_error(0, err);
+                        } else {
+                            std::thread::sleep(duration);
+                        }
+                    }
+                    Err(e) => {
+                        ctx.set_error(0, e);
                     }
                 }
-                Err(e) => {
-                    ctx.set_error(output.len(), e);
-                    output.push(0);
-                }
+            } else {
+                ctx.set_error(0, "Must be constant value");
             }
-        }),
+            Value::Scalar(0_u8)
+        },
     );
 
     registry.register_0_arg_core::<NumberType<F64>, _, _>(

src/query/functions/tests/it/scalars/testdata/other.txt

@@ -134,10 +134,10 @@ output         : "DOUBLE"
 ast            : sleep(2)
 raw expr       : sleep(2_u8)
 checked expr   : sleep<Float64>(to_float64<UInt8>(2_u8))
-optimized expr : 1_u8
+optimized expr : 0_u8
 output type    : UInt8
-output domain  : {1..=1}
-output         : 1
+output domain  : {0..=0}
+output         : 0
 
 
 error: 

src/query/sql/src/planner/optimizer/rule/rewrite/rule_push_down_filter_scan.rs

@@ -94,15 +94,16 @@ impl Rule for RulePushDownFilterScan {
         let filter: Filter = s_expr.plan().clone().try_into()?;
         let mut get: Scan = s_expr.child(0)?.plan().clone().try_into()?;
 
-        if get.push_down_predicates.is_some() {
-            return Ok(());
-        }
+        let add_filters = self.find_push_down_predicates(&filter.predicates)?;
 
-        get.push_down_predicates = Some(self.find_push_down_predicates(&filter.predicates)?);
+        match get.push_down_predicates.as_mut() {
+            Some(vs) => vs.extend(add_filters),
+            None => get.push_down_predicates = Some(add_filters),
+        }
 
-        let result = SExpr::create_unary(filter.into(), SExpr::create_leaf(get.into()));
+        let mut result = SExpr::create_unary(filter.into(), SExpr::create_leaf(get.into()));
+        result.set_applied_rule(&self.id);
         state.add_result(result);
-
         Ok(())
     }
 

tests/sqllogictests/suites/mode/standalone/explain/select.test

@@ -159,3 +159,21 @@ TableScan
 ├── partitions scanned: 1
 ├── push downs: [filters: [], limit: NONE]
 └── estimated rows: 1.00
+
+
+
+query T
+explain select * from (select * from numbers(100)  where  number> 33 ) where 1=2;
+---
+----
+Filter
+├── filters: [false, numbers.number (#0) > 33]
+├── estimated rows: 11.11
+└── TableScan
+    ├── table: default.system.numbers
+    ├── read rows: 0
+    ├── read bytes: 0
+    ├── partitions total: 0
+    ├── partitions scanned: 0
+    ├── push downs: [filters: [false], limit: NONE]
+    └── estimated rows: 100.00

tests/sqllogictests/suites/mode/standalone/explain/sort.test

@@ -58,5 +58,6 @@ Sort
         ├── output columns: [a]
         └── estimated rows: 0.00
 
+
 statement ok
 drop table if exists t1;