fix(query): fix string view memory size calculate error (#17629)

* fix(query): fix string view memory size calculate error

* fix

* fix

* fix

* fix

* fix tests

* fix tests

Author: b41sh

src/common/column/src/binview/mod.rs

@@ -297,7 +297,7 @@ impl<T: ViewType + ?Sized> BinaryViewColumnGeneric<T> {
     }
 
     pub fn memory_size(&self) -> usize {
-        self.total_buffer_len() + self.len() * 12
+        self.total_bytes_len() + self.len() * 12
     }
 
     fn total_unshared_buffer_len(&self) -> usize {

src/common/column/tests/it/binview/mod.rs

@@ -113,14 +113,25 @@ fn from_iter() {
 
 #[test]
 fn test_slice() {
-    let data = vec!["hello", "world", "databend", "y", "z", "abc"];
+    let data = vec![
+        "hello",
+        "world",
+        "databend",
+        "yyyyyyyyyyyyyyyyyyyyy",
+        "zzzzzzzzzzzzzzzzzzzzz",
+        "abcabcabcabcabcabc",
+    ];
 
     let array: Utf8ViewColumn = data.into_iter().collect();
+    assert_eq!(array.memory_size(), 150);
 
     let a3 = array.sliced(2, 3);
     assert_eq!(a3.into_iter().collect::<Vec<_>>(), vec![
-        "databend", "y", "z"
+        "databend",
+        "yyyyyyyyyyyyyyyyyyyyy",
+        "zzzzzzzzzzzzzzzzzzzzz",
     ]);
+    assert_eq!(a3.memory_size(), 86);
 }
 
 #[test]

tests/sqllogictests/suites/base/20+_others/20_0013_query_result_cache.test

@@ -89,7 +89,7 @@ EXPLAIN SELECT * FROM t1, t2 ORDER BY a, b;
 ReadQueryResultCache
 ├── SQL: SELECT * FROM t1, t2 ORDER BY a, b
 ├── Number of rows: 9
-└── Result size: 144
+└── Result size: 153
 
 
 

tests/suites/1_stateful/00_stage/00_0001_copy_into_stage.result

@@ -9,6 +9,6 @@
 2
 2
 20	160
-20	530
+20	450
 2
 20	160

tests/suites/1_stateful/05_formats/05_05_parquet/05_05_01_parquet_load_unload.result

@@ -29,14 +29,14 @@ a"b	1	['a"b']	{"k":"v"}	2044-05-06 10:25:02.868894	10.01	('a',5)	['{"k":"v"}']	[
 NULL	2	['a'b']	[1]	2044-05-06 10:25:02.868894	-10.01	('b',10)	['[1]']	[('b',10)]
 <<<<
 >>>> copy into @s1/unload1/ from test_load_unload
-2	390
+2	362
 >>>> truncate table test_load_unload
 >>>> copy into test_load_unload from @s1/unload1.parquet force=true;
 unload1.parquet	2	0	NULL	NULL
 begin diff select
 end diff
 >>>> copy into @s1/unload2/ from test_load_unload
-2	390
+2	362
 begin diff parquet
 end diff
 >>>> truncate table test_load_unload

tests/suites/1_stateful/07_stage_attachment/07_0000_insert_with_stage.result

@@ -1,7 +1,7 @@
 sample.csv
 Succeeded
 96
-192
+281
 null
 1	'Beijing'	100	China
 2	'Shanghai'	80	China

tests/suites/1_stateful/07_stage_attachment/07_0001_replace_with_stage.result

@@ -1,6 +1,6 @@
 sample.csv
 96
-192
+281
 null
 1	'Beijing'	100	China
 2	'Shanghai'	80	China

tests/suites/1_stateful/07_stage_attachment/07_0002_insert_with_stage_deduplicate.result

@@ -1,6 +1,6 @@
 sample.csv
 96
-192
+281
 null
 1	'Beijing'	100	China
 2	'Shanghai'	80	China

tests/suites/1_stateful/07_stage_attachment/07_0003_insert_with_stage_file_format.result

@@ -7,7 +7,7 @@
 <<<<
 Succeeded
 20
-27
+31
 null
 >>>> list @s1
 <<<<

tests/suites/1_stateful/08_select_stage/08_00_parquet/08_00_00_basic.result

@@ -1,9 +1,9 @@
 2
 --- named internal stage
-2	53
+2	45
 1	2	3
 4	5	6
-2	53
+2	45
 --- external stage
 1	2	3
 4	5	6