Skip to content

Commit c9e6f2c

Browse files
zhaoboranzhaoboran
authored andcommitted
rename switch settings name to use_experimental_parquet_reader
1 parent 75ee589 commit c9e6f2c

File tree

4 files changed

+11
-10
lines changed

4 files changed

+11
-10
lines changed

src/query/settings/src/settings_default.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -845,9 +845,9 @@ impl DefaultSettings {
845845
scope: SettingScope::Both,
846846
range: Some(SettingRange::Numeric(2..=u64::MAX)),
847847
}),
848-
("use_parquet2", DefaultSettingValue {
848+
("use_experimental_parquet_reader", DefaultSettingValue {
849849
value: UserSettingValue::UInt64(0),
850-
desc: "This setting is deprecated",
850+
desc: "Use experimental parquet reader to deserialize parquet data of fuse table.",
851851
mode: SettingMode::Both,
852852
scope: SettingScope::Both,
853853
range: Some(SettingRange::Numeric(0..=1)),

src/query/settings/src/settings_getter_setter.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -660,12 +660,12 @@ impl Settings {
660660
self.try_get_u64("auto_compaction_segments_limit")
661661
}
662662

663-
pub fn get_use_parquet2(&self) -> Result<bool> {
664-
Ok(self.try_get_u64("use_parquet2")? != 0)
663+
pub fn get_use_experimental_parquet_reader(&self) -> Result<bool> {
664+
Ok(self.try_get_u64("use_experimental_parquet_reader")? != 0)
665665
}
666666

667-
pub fn set_use_parquet2(&self, val: bool) -> Result<()> {
668-
self.try_set_u64("use_parquet2", u64::from(val))
667+
pub fn set_use_experimental_parquet_reader(&self, val: bool) -> Result<()> {
668+
self.try_set_u64("use_experimental_parquet_reader", u64::from(val))
669669
}
670670

671671
pub fn get_enable_replace_into_partitioning(&self) -> Result<bool> {

src/query/storages/fuse/src/io/read/block/block_reader.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ pub struct BlockReader {
5252

5353
pub original_schema: TableSchemaRef,
5454
pub native_columns_reader: NativeColumnsReader,
55-
pub use_parquet2_to_read_parquet: bool,
55+
pub use_experimental_parquet_reader: bool,
5656
}
5757

5858
fn inner_project_field_default_values(default_vals: &[Scalar], paths: &[usize]) -> Result<Scalar> {
@@ -139,7 +139,8 @@ impl BlockReader {
139139

140140
let project_indices = Self::build_projection_indices(&project_column_nodes);
141141

142-
let use_parquet2_to_read_parquet = ctx.get_settings().get_use_parquet2()?;
142+
let use_experimental_parquet_reader =
143+
ctx.get_settings().get_use_experimental_parquet_reader()?;
143144

144145
Ok(Arc::new(BlockReader {
145146
ctx,
@@ -154,7 +155,7 @@ impl BlockReader {
154155
put_cache,
155156
original_schema: schema,
156157
native_columns_reader,
157-
use_parquet2_to_read_parquet,
158+
use_experimental_parquet_reader,
158159
}))
159160
}
160161

src/query/storages/fuse/src/io/read/block/parquet/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ impl BlockReader {
5151
compression: &Compression,
5252
block_path: &str,
5353
) -> databend_common_exception::Result<DataBlock> {
54-
if self.use_parquet2_to_read_parquet {
54+
if self.use_experimental_parquet_reader {
5555
self.deserialize_v2(
5656
block_path,
5757
num_rows,

0 commit comments

Comments
 (0)