fix(expression): fix incorrect nullable array cast (#10946)

* fix(query): array cast

* fix(query): array cast

* fix(query): map cast

Author: sundy-li

src/query/expression/src/evaluator.rs

@@ -17,6 +17,7 @@ use std::ops::Not;
 
 use common_arrow::arrow::bitmap;
 use common_arrow::arrow::bitmap::Bitmap;
+use common_arrow::arrow::bitmap::MutableBitmap;
 use common_exception::ErrorCode;
 use common_exception::Result;
 use common_exception::Span;
@@ -369,6 +370,12 @@ impl<'a> Evaluator<'a> {
             },
             (DataType::Array(inner_src_ty), DataType::Array(inner_dest_ty)) => match value {
                 Value::Scalar(Scalar::Array(array)) => {
+                    let validity = validity.map(|validity| {
+                        let mut inner_validity = MutableBitmap::with_capacity(array.len());
+                        inner_validity.extend_constant(array.len(), validity.get_bit(0));
+                        inner_validity.into()
+                    });
+
                     let new_array = self
                         .run_cast(
                             span,
@@ -382,6 +389,17 @@ impl<'a> Evaluator<'a> {
                     Ok(Value::Scalar(Scalar::Array(new_array)))
                 }
                 Value::Column(Column::Array(col)) => {
+                    let validity = validity.map(|validity| {
+                        let mut inner_validity = MutableBitmap::with_capacity(col.len());
+                        for (index, offsets) in col.offsets.windows(2).enumerate() {
+                            inner_validity.extend_constant(
+                                (offsets[1] - offsets[0]) as usize,
+                                validity.get_bit(index),
+                            );
+                        }
+                        inner_validity.into()
+                    });
+
                     let new_col = self
                         .run_cast(
                             span,
@@ -415,6 +433,12 @@ impl<'a> Evaluator<'a> {
             },
             (DataType::Map(inner_src_ty), DataType::Map(inner_dest_ty)) => match value {
                 Value::Scalar(Scalar::Map(array)) => {
+                    let validity = validity.map(|validity| {
+                        let mut inner_validity = MutableBitmap::with_capacity(array.len());
+                        inner_validity.extend_constant(array.len(), validity.get_bit(0));
+                        inner_validity.into()
+                    });
+
                     let new_array = self
                         .run_cast(
                             span,
@@ -428,6 +452,12 @@ impl<'a> Evaluator<'a> {
                     Ok(Value::Scalar(Scalar::Map(new_array)))
                 }
                 Value::Column(Column::Map(col)) => {
+                    let validity = validity.map(|validity| {
+                        let mut inner_validity = MutableBitmap::with_capacity(col.len());
+                        inner_validity.extend_constant(col.len(), validity.get_bit(0));
+                        inner_validity.into()
+                    });
+
                     let new_col = self
                         .run_cast(
                             span,

tests/sqllogictests/suites/duckdb/sql/cast/double_float_cast.test

@@ -21,4 +21,3 @@ Infinity
 
 # ----
 # -Infinity
-

tests/sqllogictests/suites/duckdb/sql/cast/float_integer_cast.test

@@ -59,4 +59,3 @@
 
 # ----
 # -2
-

tests/sqllogictests/suites/duckdb/sql/cast/test_boolean_cast.test

@@ -127,4 +127,3 @@ query I
 SELECT CAST(CAST('0' AS BIGINT) AS BOOLEAN)
 ----
 0
-

tests/sqllogictests/suites/duckdb/sql/cast/test_exponent_in_cast.test

@@ -30,4 +30,3 @@ SELECT CAST('1e1' AS DOUBLE)
 
 # ----
 # 10.0
-

tests/sqllogictests/suites/duckdb/sql/cast/test_string_cast.test

@@ -78,4 +78,3 @@ SELECT 2::DOUBLE::VARCHAR, 0.5::DOUBLE::VARCHAR, (-128.5)::DOUBLE::VARCHAR
 
 # ----
 # 0
-

tests/sqllogictests/suites/duckdb/sql/cast/test_try_cast.test

@@ -34,4 +34,3 @@ query I
 SELECT try_cast(try_cast(try_cast as integer) as integer) FROM try_cast
 ----
 3
-

tests/sqllogictests/suites/duckdb/sql/cast/timestamp_date_cast.test

@@ -11,4 +11,3 @@ statement error 1065
 select *
 from test
 where (t::date) = '2021-02-04'
-

tests/sqllogictests/suites/query/functions/cast.test

@@ -28,6 +28,7 @@ select try_cast(3 as int);
 ----
 3
 
+
 statement error
 select int_nullable::int from cast_test
 
@@ -49,8 +50,24 @@ INSERT INTO t1(c1boolean, c0varchar) VALUES (true, '0')
 statement ok
 SELECT (false and NULL NOT IN (0.1, 0.2, 0.3,0.4)) ::BIGINT FROM t1,t0
 
+
+statement ok
+create table cast_array (t Array(String NULL) NULL )
+
+statement ok
+insert into cast_array values([1,2]), ([1, 555])
+
+query T
+select cast(t as Array(String) Null) from cast_array
+----
+['1','2']
+['1','555']
+
 statement ok
 drop table t0
 
+statement ok
+drop table cast_array
+
 statement ok
 drop table t1