fix(query): don't check file format in proto-conv (#17793)

* fix(query): don't check file format in proto-conv

* fix(query): don't check file format in proto-conv

Author: sundy-li

src/meta/app/src/principal/file_format.rs

@@ -782,14 +782,6 @@ impl ParquetFileFormatParams {
         missing_field_as: Option<&str>,
         null_if: Vec<String>,
     ) -> Result<Self> {
-        if !matches!(
-            compression,
-            StageFileCompression::Zstd | StageFileCompression::Snappy
-        ) {
-            return Err(ErrorCode::InvalidArgument(format!(
-                "compression algorithm {compression} not supported, only support Zstd and Snappy."
-            )));
-        }
         let missing_field_as = NullAs::parse(missing_field_as, MISSING_FIELD_AS, NullAs::Error)?;
         Ok(Self {
             compression,

src/query/storages/stage/src/append/parquet_file/writer_processor.rs

@@ -132,6 +132,7 @@ impl ParquetFileWriter {
         let compression = match &compression {
             StageFileCompression::Zstd => Compression::ZSTD(ZstdLevel::default()),
             StageFileCompression::Snappy => Compression::SNAPPY,
+            StageFileCompression::None => Compression::UNCOMPRESSED,
             _ => {
                 return Err(ErrorCode::Internal(format!(
                     "unexpected compression {compression}"

src/query/storages/stage/src/compression.rs

@@ -31,12 +31,12 @@ pub fn get_compression_alg_copy(
         StageFileCompression::Xz => Some(CompressAlgorithm::Xz),
         StageFileCompression::Lzo => {
             return Err(ErrorCode::Unimplemented(
-                "compress type lzo is unimplemented",
+                "compress type lzo is unimplemented for copy into",
             ));
         }
         StageFileCompression::Snappy => {
             return Err(ErrorCode::Unimplemented(
-                "compress type snappy is unimplemented",
+                "compress type snappy is unimplemented  for copy into",
             ));
         }
         StageFileCompression::None => None,

tests/sqllogictests/suites/stage/formats/parquet/options/parquet_compression.test

@@ -1,12 +1,18 @@
 statement ok
 create or replace file format parquet_snappy type=parquet compression=snappy
 
+statement ok
+create or replace file format parquet_none type=parquet compression=none
+
 statement ok
 remove @data/unload/parquet_compression/snappy.parquet
 
 statement ok
 copy into @data/unload/parquet_compression/snappy.parquet from (select * from numbers(3)) file_format=(format_name='parquet_snappy')
 
+statement ok
+copy into @data/unload/parquet_compression/none.parquet from (select * from numbers(3)) file_format=(format_name='parquet_none')
+
 statement ok
 copy into @data/unload/parquet_compression/zstd.parquet from (select * from numbers(3))
 
@@ -21,4 +27,7 @@ statement ok
 remove @data/unload/parquet_compression/snappy.parquet
 
 statement ok
-remove @data/unload/parquet_compression/zstd.parquet
+remove @data/unload/parquet_compression/zstd.parquet
+
+statement ok
+remove @data/unload/parquet_compression/none.parquet

tests/sqllogictests/suites/stage/unload.test

@@ -1,5 +1,7 @@
 # need to run with '-p 0'
 
+control sortmode rowsort
+
 statement ok
 drop stage if exists unload;
 
@@ -21,19 +23,26 @@ insert into ii values (1, 2), (3, 4), (5, 6);
 statement ok
 create file format if not exists csv_gzip type=csv compression=gzip;
 
+statement ok
+create file format if not exists csv_snappy type=csv compression=snappy;
+
+statement ok
+create file format if not exists csv_none type=csv compression=none;
+
+
 # test csv
-query 
+query
 copy into @unload from ii file_format=(type=csv);
 -----
 ----
 3 12 12
 
-query 
+query
 select right(name, 4), size from list_stage(location=>'@unload');
 ----
 .csv 12
 
-query 
+query
 select $1, $2 from @unload(file_format=>'csv');
 ----
 1 2
@@ -44,18 +53,34 @@ select $1, $2 from @unload(file_format=>'csv');
 statement ok
 remove @unload;
 
-query 
+query
 copy into @unload from ii file_format=(format_name='csv_gzip');
 ----
 3 12 32
 
-query 
+statement error
+copy into @unload from ii file_format=(format_name='csv_snappy');
+
+query
+copy into @unload from ii file_format=(format_name='csv_none');
+----
+3 12 12
+
+query
 select right(name, 7), size from list_stage(location=>'@unload');
 ----
 .csv.gz 32
+000.csv 12
 
-query 
-select $1, $2 from @unload(file_format => 'csv_gzip');
+query
+select $1, $2 from @unload(file_format => 'csv_gzip' pattern => '.*.gz');
+----
+1 2
+3 4
+5 6
+
+query
+select $1, $2 from @unload(file_format => 'csv_none' pattern => '.*.csv');
 ----
 1 2
 3 4
@@ -65,17 +90,17 @@ select $1, $2 from @unload(file_format => 'csv_gzip');
 statement ok
 remove @unload;
 
-query 
+query
 copy into @unload from ii file_format=(format_name='tsv');
 ----
 3 12 12
 
-query 
+query
 select right(name, 4), size from list_stage(location=>'@unload');
 ----
 .tsv 12
 
-query 
+query
 select $1, $2 from @unload(file_format => 'tsv');
 ----
 1 2