fix(bind): disable the shrink constant when it is a generic type argument of a function (#18145)

disable the shrink constant when it is a generic type argument of a function

Author: forsaken628

src/query/expression/src/utils/mod.rs

@@ -35,6 +35,7 @@ use crate::types::decimal::MAX_DECIMAL256_PRECISION;
 use crate::types::i256;
 use crate::types::AnyType;
 use crate::types::DataType;
+use crate::types::Decimal;
 use crate::types::DecimalDataKind;
 use crate::types::DecimalSize;
 use crate::types::NumberScalar;
@@ -180,7 +181,7 @@ fn shrink_d256(decimal: i256, size: DecimalSize) -> Scalar {
     let log10_2 = std::f64::consts::LOG10_2;
     let mut precision = ((valid_bits as f64) * log10_2).floor() as u8;
 
-    if decimal.saturating_abs() >= i256::from(10).pow(precision as u32) {
+    if decimal.saturating_abs() >= i256::e(precision) {
         precision += 1;
     }
 

src/query/sql/src/planner/semantic/type_check.rs

@@ -3032,21 +3032,25 @@ impl<'a> TypeChecker<'a> {
 
         let mut folded_args = match &expr {
             expr::Expr::FunctionCall(expr::FunctionCall {
-                args: checked_args, ..
-            }) => {
-                let mut folded_args = Vec::with_capacity(args.len());
-                for (checked_arg, arg) in checked_args.iter().zip(args.iter()) {
-                    match self.try_fold_constant(checked_arg, true) {
-                        Some(constant) if arg.evaluable() => {
-                            folded_args.push(constant.0);
-                        }
-                        _ => {
-                            folded_args.push(arg.clone());
-                        }
-                    }
-                }
-                folded_args
-            }
+                function,
+                args: checked_args,
+                ..
+            }) => checked_args
+                .iter()
+                .zip(
+                    function
+                        .signature
+                        .args_type
+                        .iter()
+                        .map(DataType::is_generic),
+                )
+                .map(|(checked_arg, is_generic)| self.try_fold_constant(checked_arg, !is_generic))
+                .zip(args)
+                .map(|(folded, arg)| match folded {
+                    Some(box (constant, _)) if arg.evaluable() => constant,
+                    _ => arg,
+                })
+                .collect(),
             _ => args,
         };
 

tests/sqllogictests/suites/query/functions/02_0058_function_ifnull.test

@@ -87,6 +87,12 @@ NULL 0 0
 NULL 1 1
 NULL NULL NULL
 
+query R
+select ifnull(number::string, 0) from numbers(3);
+----
+0.00000
+1.00000
+2.00000
+
 statement ok
 DROP TABLE t
-