refactor: remove unused field step from sequence meta (#18245)

* refactor: remove unused field `start` from `SequenceMeta`

This is a **Non-Breaking** change.

* refactor: nexval call on a sequence should not update the last-updated timestamp

Because nextval is not a DDL operation.

Author: drmingdrmer

src/meta/api/src/sequence_api_impl.rs

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-use chrono::Utc;
 use databend_common_meta_app::app_error::AppError;
 use databend_common_meta_app::app_error::OutofSequenceRange;
 use databend_common_meta_app::app_error::SequenceError;
@@ -152,7 +151,6 @@ impl<KV: kvapi::KVApi<Error = MetaError> + ?Sized> SequenceApi for KV {
 
             // update meta
             sequence_meta.current += count;
-            sequence_meta.update_on = Utc::now();
 
             let condition = vec![txn_cond_eq_seq(&ident, sequence_seq)];
             let if_then = vec![

src/meta/app/src/schema/sequence.rs

@@ -28,7 +28,6 @@ pub struct SequenceMeta {
     pub create_on: DateTime<Utc>,
     pub update_on: DateTime<Utc>,
     pub comment: Option<String>,
-    pub start: u64,
     pub step: i64,
     pub current: u64,
 }
@@ -39,7 +38,6 @@ impl From<CreateSequenceReq> for SequenceMeta {
             comment: p.comment.clone(),
             create_on: p.create_on,
             update_on: p.create_on,
-            start: 1,
             step: 1,
             current: 1,
         }

src/meta/proto-conv/src/sequence_from_to_protobuf_impl.rs

@@ -38,7 +38,6 @@ impl FromToProto for SequenceMeta {
             comment: p.comment.clone(),
             create_on: DateTime::<Utc>::from_pb(p.create_on)?,
             update_on: DateTime::<Utc>::from_pb(p.update_on)?,
-            start: p.start,
             current: p.current,
             step: p.step,
         };
@@ -52,7 +51,6 @@ impl FromToProto for SequenceMeta {
             comment: self.comment.clone(),
             create_on: self.create_on.to_pb()?,
             update_on: self.update_on.to_pb()?,
-            start: self.start,
             current: self.current,
             step: self.step,
         };

src/meta/proto-conv/src/util.rs

@@ -161,6 +161,7 @@ const META_CHANGE_LOG: &[(u64, &str)] = &[
     (129, "2025-05-30: Add: New DataType Vector"),
     (130, "2025-06-19: Add: New UDF imports and packages in udf definition"),
     (131, "2025-06-24: Add: add use_logic_type in ParquetFileFormatParam and AvroFileFormatParam"),
+    (132, "2025-06-25: Remove: SequenceMeta.start"),
     // Dear developer:
     //      If you're gonna add a new metadata version, you'll have to add a test for it.
     //      You could just copy an existing test file(e.g., `../tests/it/v024_table_meta.rs`)

src/meta/proto-conv/tests/it/main.rs

@@ -123,3 +123,4 @@ mod v128_storage_network_config;
 mod v129_vector_datatype;
 mod v130_udf_imports_packages;
 mod v131_avro_and_parquet_file_format_params;
+mod v132_remove_sequence_meta_start;

src/meta/proto-conv/tests/it/proto_conv.rs

@@ -82,7 +82,6 @@ fn new_sequence_meta() -> mt::SequenceMeta {
         create_on: DateTime::<Utc>::from_timestamp(10267, 0).unwrap(),
         update_on: DateTime::<Utc>::from_timestamp(10267, 0).unwrap(),
         comment: Some("seq".to_string()),
-        start: 1,
         step: 1,
         current: 10,
     }

src/meta/proto-conv/tests/it/v088_sequence_meta.rs

@@ -31,7 +31,6 @@ fn test_decode_v88_sequence_meta() -> anyhow::Result<()> {
         create_on: DateTime::<Utc>::from_timestamp(10267, 0).unwrap(),
         update_on: DateTime::<Utc>::from_timestamp(10267, 0).unwrap(),
         comment: Some("seq".to_string()),
-        start: 1,
         step: 1,
         current: 10,
     };

src/meta/proto-conv/tests/it/v132_remove_sequence_meta_start.rs

@@ -0,0 +1,41 @@
+// Copyright 2023 Datafuse Labs.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+use chrono::DateTime;
+use chrono::Utc;
+use databend_common_meta_app::schema as mt;
+use fastrace::func_name;
+
+use crate::common;
+
+#[test]
+fn test_decode_v132_remove_sequence_meta_step() -> anyhow::Result<()> {
+    let sequence_meta_v132 = vec![
+        10, 23, 49, 57, 55, 48, 45, 48, 49, 45, 48, 49, 32, 48, 50, 58, 53, 49, 58, 48, 55, 32, 85,
+        84, 67, 18, 23, 49, 57, 55, 48, 45, 48, 49, 45, 48, 49, 32, 48, 50, 58, 53, 49, 58, 48, 55,
+        32, 85, 84, 67, 26, 3, 115, 101, 113, 40, 5, 48, 10, 160, 6, 132, 1, 168, 6, 24,
+    ];
+
+    let want = || mt::SequenceMeta {
+        create_on: DateTime::<Utc>::from_timestamp(10267, 0).unwrap(),
+        update_on: DateTime::<Utc>::from_timestamp(10267, 0).unwrap(),
+        comment: Some("seq".to_string()),
+        step: 5,
+        current: 10,
+    };
+    common::test_pb_from_to(func_name!(), want())?;
+    common::test_load_old(func_name!(), sequence_meta_v132.as_slice(), 132, want())?;
+
+    Ok(())
+}

src/meta/protos/proto/sequence.proto

@@ -23,7 +23,11 @@ message SequenceMeta {
   string create_on = 1;
   string update_on = 2;
   optional string comment = 3;
-  uint64 start = 4;
+
+  // reserved: start is not used and is removed.
+  //  uint64 start = 4;
+  reserved 4;
+
   int64 step = 5;
   uint64 current = 6;
 }

src/meta/service/tests/it/api/http/features.rs

@@ -99,6 +99,9 @@ async fn test_features() -> anyhow::Result<()> {
     let features: FeatureResponse = serde_json::from_str(&text).unwrap();
     assert_eq!(features.enabled, vec!["dummy".to_string()]);
 
+    // Wait for node-1 to catch up
+    tokio::time::sleep(Duration::from_secs(1)).await;
+
     // node-1 list features
     let resp = client.get(list_features_url(1)).send().await;
     println!("node-1 features resp: {:?}", resp);