Skip to content

Commit f3dce95

Browse files
authored
1 parent c6b8621 commit f3dce95

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

src/query/service/src/interpreters/interpreter_table_create.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -342,6 +342,7 @@ impl CreateTableInterpreter {
342342
invalid_cache = true;
343343
}
344344

345+
// TODO: can refactor into create_table in one txn
345346
// if old_table_id is some means create or replace is success, we should delete the old table id's ownership key
346347
if let Some(old_table_id) = reply.old_table_id {
347348
role_api

src/query/service/tests/it/storages/fuse/operations/create_or_replace_ownership_object.rs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ use databend_common_base::base::tokio;
1818
use databend_common_config::MetaConfig;
1919
use databend_common_exception::ErrorCode;
2020
use databend_common_exception::Result;
21-
use databend_common_meta_api::SchemaApi;
21+
use databend_common_meta_api::kv_pb_api::KVPbApi;
2222
use databend_common_meta_app::principal::OwnershipObject;
2323
use databend_common_meta_app::principal::TenantOwnershipObjectIdent;
2424
use databend_common_meta_store::MetaStore;
@@ -87,7 +87,7 @@ async fn test_fuse_db_table_create_replace_clean_ownership_key() -> Result<()> {
8787
table_id: old_tbl_id,
8888
};
8989
let table_ownership_key = TenantOwnershipObjectIdent::new(tenant.clone(), table_ownership);
90-
let v = meta.get(&table_ownership_key).await?;
90+
let v = meta.get_pb(&table_ownership_key).await?;
9191
assert!(v.is_some());
9292

9393
fixture
@@ -96,7 +96,7 @@ async fn test_fuse_db_table_create_replace_clean_ownership_key() -> Result<()> {
9696
catalog_name, db_name, tbl_name
9797
))
9898
.await?;
99-
let v = meta.get(&table_ownership_key).await?;
99+
let v = meta.get_pb(&table_ownership_key).await?;
100100
assert!(v.is_none());
101101

102102
let tbl_name = "ownership_table_test";
@@ -115,7 +115,7 @@ async fn test_fuse_db_table_create_replace_clean_ownership_key() -> Result<()> {
115115
};
116116
let table_ownership_key =
117117
TenantOwnershipObjectIdent::new(tenant.clone(), table_ownership.clone());
118-
let v = meta.get(&table_ownership_key).await?;
118+
let v = meta.get_pb(&table_ownership_key).await?;
119119
assert!(v.is_some());
120120

121121
fixture
@@ -128,7 +128,7 @@ async fn test_fuse_db_table_create_replace_clean_ownership_key() -> Result<()> {
128128
let second_create_id = tbl.get_table_info().ident.table_id;
129129
assert_ne!(second_create_id, first_create_id);
130130
let db_ownership_key = TenantOwnershipObjectIdent::new(tenant.clone(), table_ownership);
131-
let v = meta.get(&db_ownership_key).await?;
131+
let v = meta.get_pb(&db_ownership_key).await?;
132132
assert!(v.is_none());
133133

134134
let table_ownership = OwnershipObject::Table {
@@ -137,7 +137,7 @@ async fn test_fuse_db_table_create_replace_clean_ownership_key() -> Result<()> {
137137
table_id: second_create_id,
138138
};
139139
let db_ownership_key = TenantOwnershipObjectIdent::new(tenant.clone(), table_ownership);
140-
let v = meta.get(&db_ownership_key).await?;
140+
let v = meta.get_pb(&db_ownership_key).await?;
141141
assert!(v.is_some());
142142
}
143143

@@ -159,7 +159,7 @@ async fn test_fuse_db_table_create_replace_clean_ownership_key() -> Result<()> {
159159
};
160160
let db_ownership_key =
161161
TenantOwnershipObjectIdent::new(tenant.clone(), db_ownership.clone());
162-
let v = meta.get(&db_ownership_key).await?;
162+
let v = meta.get_pb(&db_ownership_key).await?;
163163
assert!(v.is_some());
164164

165165
fixture
@@ -173,15 +173,15 @@ async fn test_fuse_db_table_create_replace_clean_ownership_key() -> Result<()> {
173173
assert_ne!(second_create_db_id, first_create_db_id);
174174

175175
let db_ownership_key = TenantOwnershipObjectIdent::new(tenant.clone(), db_ownership);
176-
let v = meta.get(&db_ownership_key).await?;
176+
let v = meta.get_pb(&db_ownership_key).await?;
177177
assert!(v.is_none());
178178

179179
let db_ownership = OwnershipObject::Database {
180180
catalog_name: catalog_name.clone(),
181181
db_id: *second_create_db_id,
182182
};
183183
let db_ownership_key = TenantOwnershipObjectIdent::new(tenant.clone(), db_ownership);
184-
let v = meta.get(&db_ownership_key).await?;
184+
let v = meta.get_pb(&db_ownership_key).await?;
185185
assert!(v.is_some());
186186
}
187187

0 commit comments

Comments
 (0)