ci: add workspace-hack #18363
ci: add workspace-hack #18363
Conversation
🤖 Smart Auto-retry Analysis (Retry 1)
📊 Summary
❌ NO RETRY NEEDEDAll failures appear to be code/test issues requiring manual fixes. 🔍 Job Details
🤖 AboutAutomated analysis using job annotations to distinguish infrastructure issues (auto-retried) from code/test issues (manual fixes needed). |
There was a problem hiding this comment.
Pull Request Overview
This PR integrates a generated “workspace hack” crate (databend-workspace-hack) into the workspace to unify dependency versions across all member crates via Cargo Hakari. Key changes include:
- Adding
databend-workspace-hackas a path dependency in everyCargo.tomlto ensure consistent versions. - Introducing the
databend-workspace-hackcrate stub with alib.rs,build.rs, a generatedCargo.toml, and merge settings. - Disabling the
unused_crate_dependencieslint incommon/buildingto avoid errors from the additional hack dependency.
Reviewed Changes
Copilot reviewed 115 out of 116 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
Cargo.toml |
Added databend-workspace-hack to workspace members. |
Many src/.../Cargo.toml files |
Added databend-workspace-hack = { version = "0.1", path = ... } under [dependencies]. |
databend-workspace-hack/src/lib.rs |
Created stub library file. |
databend-workspace-hack/build.rs |
Added empty build script. |
databend-workspace-hack/Cargo.toml |
Generated Hakari-managed dependency list. |
databend-workspace-hack/.gitattributes |
Configured merge and line endings. |
src/common/building/src/lib.rs |
Commented out #![deny(unused_crate_dependencies)]. |
.config/hakari.toml |
Added configuration for Cargo Hakari. |
Comments suppressed due to low confidence (2)
databend-workspace-hack/src/lib.rs:1
- Add the standard Apache license header to this file to maintain consistency with the rest of the codebase and clarify that this crate is under the project’s license.
// This is a stub lib.rs.
databend-workspace-hack/build.rs:1
- Include the project’s license header at the top of this build script to match repository conventions and ensure legal clarity.
// A build script is required for cargo to consider build dependencies.
| @@ -12,7 +12,7 @@ | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
|
|
|||
| #![deny(unused_crate_dependencies)] | |||
| // #![deny(unused_crate_dependencies)] | |||
There was a problem hiding this comment.
Instead of commenting out the lint directive, replace it with #![allow(unused_crate_dependencies)] at the crate root. This explicitly documents that the hack crate injection is intentional and avoids leaving commented code.
| // #![deny(unused_crate_dependencies)] | |
| #![allow(unused_crate_dependencies)] |
Copilot uses AI. Check for mistakes.
| @@ -0,0 +1,341 @@ | |||
| # This file is generated by `cargo hakari`. | |||
| # To regenerate, run: | |||
| # cargo hakari generate | |||
There was a problem hiding this comment.
scripts/setup/dev_setup.sh should update
|
Not having found a good solution for cargo machete and cargo hakari to coexist, I think manually maintaining the workspace-hack will suffice for our needs. |
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Tests
Type of change
This change is