refactor(sql): improve agg index rewrite matching#19567
Draft
forsaken628 wants to merge 13 commits intodatabendlabs:mainfrom
Draft
refactor(sql): improve agg index rewrite matching#19567forsaken628 wants to merge 13 commits intodatabendlabs:mainfrom
forsaken628 wants to merge 13 commits intodatabendlabs:mainfrom
Conversation
github-actions
bot
added
the
pr-refactor
# Conflicts: # src/query/sql/tests/it/framework/golden.rs # src/query/sql/tests/it/framework/lite_context.rs # src/query/sql/tests/it/framework/mod.rs # src/query/sql/tests/it/optimizer/eager_aggregation.rs # src/query/sql/tests/it/optimizer/eager_aggregation.txt # src/query/sql/tests/it/optimizer/mod.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
This PR refactors aggregating index rewrite to use structural expression matching instead of string-based matching.
Tests
Type of change
This change is