FIX: Fix C++ client CI

- Fix syntax of multiline commands in `build.yaml`
- Disable cppcheck due to old version in CI that can't parse
  `enum class`es
- Disable clang-tidy for examples due to lack of support for
  `NOLINTBEGIN`
- Add missing `throw`

Author: threecgreen

.github/workflows/build.yaml

@@ -10,25 +10,27 @@ jobs:
   ubuntu:
     strategy:
       matrix:
-        compiler: [clang, gcc]
+        compiler: [clang++, g++]
 
-    name: build - ubuntu-latest - (${{ matrix.compiler}})
+    name: build - ubuntu-latest - ${{ matrix.compiler}}
     runs-on: ubuntu-latest
 
     steps:
       - name: Checkout repository
         uses: actions/checkout@v3
       - name: Install dependencies
-        run: sudo apt-get install libzstd-dev ninja-build libgtest-dev
+        run: |
+          sudo apt-get update
+          sudo apt-get install libzstd-dev ninja-build
       - name: Install gtest
         uses: MarkusJx/[email protected]
       - name: CMake configure
-        run: cmake -S . -B build \
-          -GNinja \
-          -DCMAKE_CXX_COMPILER=${{ matrix.compiler }} \
-          -DCMAKE_ENABLE_EXAMPLES=1 \
-          -DDATABENTO_ENABLE_CLANG_TIDY=1 \
-          -DDATABENTO_ENABLE_CPPCHECK=1
+        run: |
+          cmake -S . -B build \
+            -GNinja \
+            -DCMAKE_CXX_COMPILER=${{ matrix.compiler }} \
+            -DDATABENTO_ENABLE_EXAMPLES=1 \
+            -DDATABENTO_ENABLE_CLANG_TIDY=1
       - name: CMake build
         run: cmake --build build
       - name: Unit tests

CMakeLists.txt

@@ -310,7 +310,8 @@ if(${PROJECT_NAME_UPPERCASE}_ENABLE_UNIT_TESTING)
 endif()
 
 if(${PROJECT_NAME_UPPERCASE}_ENABLE_EXAMPLES)
-  unset(CMAKE_CXX_CPPCHECK) # disable cppcheck for tests
+  unset(CMAKE_CXX_CPPCHECK) # disable cppcheck for examples
+  unset(CMAKE_CXX_CLANG_TIDY) # disable clang-tidy for examples
   message(STATUS "Build examples for the project.")
   add_subdirectory(example)
 endif()

src/historical.cpp

@@ -334,7 +334,7 @@ std::vector<databento::BatchJob> Historical::BatchListJobs(
   static const std::string kPath = ::BuildBatchPath(".list_jobs");
   const nlohmann::json json = client_.GetJson(kPath, params);
   if (!json.is_array()) {
-    JsonResponseError::TypeMismatch(kEndpoint, "array", json);
+    throw JsonResponseError::TypeMismatch(kEndpoint, "array", json);
   }
   std::vector<BatchJob> jobs;
   jobs.reserve(json.size());