DEL: Remove default_value param from C++ client

Author: threecgreen

CHANGELOG.md

@@ -10,6 +10,9 @@
 - Added `map_symbols`, `pretty_px`, and `pretty_ts` to `BatchJob` response
 - Added `ARCX.PILLAR.ARCX` publisher
 
+### Breaking changes
+- Remove `default_value` parameter from `Historical::SymbologyResolve`
+
 ## 0.12.1 - 2023-08-25
 ### Bug fixes
 - Fixed typo in `BATY.PITCH.BATY` publisher

include/databento/historical.hpp

@@ -155,11 +155,6 @@ class Historical {
                                        const std::vector<std::string>& symbols,
                                        SType stype_in, SType stype_out,
                                        const DateRange& date_range);
-  SymbologyResolution SymbologyResolve(const std::string& dataset,
-                                       const std::vector<std::string>& symbols,
-                                       SType stype_in, SType stype_out,
-                                       const DateRange& date_range,
-                                       const std::string& default_value);
 
   /*
    * Timeseries API

scripts/test.sh

@@ -1,3 +1,3 @@
 #! /usr/bin/env bash
 cd build
-ctest --timeout 300 --output-on-failure --tests-regex databentoTests
+ctest --timeout 300 --output-on-failure --exclude-regex 'cmake_fetch_content.*'

src/historical.cpp

@@ -733,13 +733,6 @@ double Historical::MetadataGetCost(const HttplibParams& params) {
 databento::SymbologyResolution Historical::SymbologyResolve(
     const std::string& dataset, const std::vector<std::string>& symbols,
     SType stype_in, SType stype_out, const DateRange& date_range) {
-  return this->SymbologyResolve(dataset, symbols, stype_in, stype_out,
-                                date_range, {});
-}
-databento::SymbologyResolution Historical::SymbologyResolve(
-    const std::string& dataset, const std::vector<std::string>& symbols,
-    SType stype_in, SType stype_out, const DateRange& date_range,
-    const std::string& default_value) {
   static const std::string kEndpoint = "Historical::SymbologyResolve";
   static const std::string kPath = ::BuildSymbologyPath(".resolve");
   httplib::Params params{{"dataset", dataset},
@@ -748,7 +741,6 @@ databento::SymbologyResolution Historical::SymbologyResolve(
                          {"stype_in", ToString(stype_in)},
                          {"stype_out", ToString(stype_out)}};
   detail::SetIfNotEmpty(&params, "end_date", date_range.end);
-  detail::SetIfNotEmpty(&params, "default_value", default_value);
   const nlohmann::json json = client_.PostJson(kPath, params);
   if (!json.is_object()) {
     throw JsonResponseError::TypeMismatch(kEndpoint, "object", json);

test/src/historical_tests.cpp

@@ -62,6 +62,7 @@ TEST_F(HistoricalTests, TestBatchSubmitJob) {
       {"packaging", nullptr},
       {"pretty_px", false},
       {"pretty_ts", false},
+      {"map_symbols", false},
       {"progress", 100},
       {"record_count", 107418},
       {"schema", "trades"},
@@ -86,7 +87,7 @@ TEST_F(HistoricalTests, TestBatchSubmitJob) {
                              {"end", "2022-07-03"},
                              {"encoding", "dbn"},
                              {"compression", "zstd"},
-                             {"map_symbols", "false"},
+                             {"map_symbols", "0"},
                              {"symbols", "CLH3"},
                              {"schema", "trades"}},
                             kResp);
@@ -155,6 +156,7 @@ TEST_F(HistoricalTests, TestBatchListJobs) {
        {"packaging", nullptr},
        {"pretty_px", false},
        {"pretty_ts", false},
+       {"map_symbols", false},
        {"progress", 100},
        {"record_count", 107418},
        {"schema", "trades"},