MOD: Revert to metadata.get_dataset_condition

Author: cjdsellers

CHANGELOG.md

@@ -2,7 +2,7 @@
 
 ## 0.5.0 - TBD
 - Added `Historical::MetadataGetDatasetRange`
-- Renamed `MetadataGetDatasetCondition` to `MetadataListDatasetConditions`
+- Changed `MetadataGetDatasetCondition` to return `vector<DatasetConditionDetail>`
 
 ## 0.4.0 - 2023-03-02
 - Renamed DBZ to DBN

example/historical/metadata.cpp

@@ -50,7 +50,7 @@ int main() {
   }
   std::cout << '\n';
 
-  const auto dataset_conditions = client.MetadataListDatasetConditions(
+  const auto dataset_conditions = client.MetadataGetDatasetCondition(
       "GLBX.MDP3", "2019-06-01", "2019-08-01");
   std::cout << "Conditions:\n";
   for (const auto& dataset_condition : dataset_conditions) {

include/databento/historical.hpp

@@ -93,9 +93,9 @@ class Historical {
                                          Schema schema);
   double MetadataListUnitPrices(const std::string& dataset, FeedMode mode,
                                 Schema schema);
-  std::vector<DatasetConditionDetail> MetadataListDatasetConditions(
+  std::vector<DatasetConditionDetail> MetadataGetDatasetCondition(
       const std::string& dataset);
-  std::vector<DatasetConditionDetail> MetadataListDatasetConditions(
+  std::vector<DatasetConditionDetail> MetadataGetDatasetCondition(
       const std::string& dataset, const std::string& start_date,
       const std::string& end_date);
   DatasetRange MetadataGetDatasetRange(const std::string& dataset);
@@ -245,7 +245,7 @@ class Historical {
   BatchJob BatchSubmitJob(const HttplibParams& params);
   void DownloadFile(const std::string& url, const std::string& output_path);
   std::vector<BatchJob> BatchListJobs(const HttplibParams& params);
-  std::vector<DatasetConditionDetail> MetadataListDatasetConditions(
+  std::vector<DatasetConditionDetail> MetadataGetDatasetCondition(
       const HttplibParams& params);
   std::size_t MetadataGetRecordCount(const HttplibParams& params);
   std::size_t MetadataGetBillableSize(const HttplibParams& params);

src/historical.cpp

@@ -722,26 +722,25 @@ double Historical::MetadataListUnitPrices(const std::string& dataset,
 }
 
 std::vector<databento::DatasetConditionDetail>
-Historical::MetadataListDatasetConditions(const std::string& dataset) {
-  return MetadataListDatasetConditions(httplib::Params{{"dataset", dataset}});
+Historical::MetadataGetDatasetCondition(const std::string& dataset) {
+  return MetadataGetDatasetCondition(httplib::Params{{"dataset", dataset}});
 }
 
 std::vector<databento::DatasetConditionDetail>
-Historical::MetadataListDatasetConditions(const std::string& dataset,
-                                          const std::string& start_date,
-                                          const std::string& end_date) {
-  return MetadataListDatasetConditions(
-      httplib::Params{{"dataset", dataset},
-                      {"start_date", start_date},
-                      {"end_date", end_date}});
+Historical::MetadataGetDatasetCondition(const std::string& dataset,
+                                        const std::string& start_date,
+                                        const std::string& end_date) {
+  return MetadataGetDatasetCondition(httplib::Params{{"dataset", dataset},
+                                                     {"start_date", start_date},
+                                                     {"end_date", end_date}});
 }
 
 std::vector<databento::DatasetConditionDetail>
-Historical::MetadataListDatasetConditions(const httplib::Params& params) {
+Historical::MetadataGetDatasetCondition(const httplib::Params& params) {
   static const std::string kEndpoint =
-      "Historical::MetadataListDatasetConditions";
+      "Historical::MetadataGetDatasetCondition";
   static const std::string kPath =
-      ::BuildMetadataPath(".list_dataset_conditions");
+      ::BuildMetadataPath(".get_dataset_condition");
   const nlohmann::json json = client_.GetJson(kPath, params);
   if (!json.is_array()) {
     throw JsonResponseError::TypeMismatch(kEndpoint, "array", json);

test/src/historical_tests.cpp

@@ -397,13 +397,13 @@ TEST_F(HistoricalTests, TestMetadataListCompressions) {
   EXPECT_EQ(res, kExp);
 }
 
-TEST_F(HistoricalTests, TestMetadataListDatasetConditions) {
+TEST_F(HistoricalTests, TestMetadataGetDatasetCondition) {
   const nlohmann::json kResp{
       {{"date", "2022-11-07"}, {"condition", "available"}},
       {{"date", "2022-11-08"}, {"condition", "bad"}},
       {{"date", "2022-11-09"}, {"condition", "bad"}},
       {{"date", "2022-11-10"}, {"condition", "available"}}};
-  mock_server_.MockGetJson("/v0/metadata.list_dataset_conditions",
+  mock_server_.MockGetJson("/v0/metadata.get_dataset_condition",
                            {{"dataset", dataset::kXnasItch},
                             {"start_date", "2022-11-06"},
                             {"end_date", "2022-11-10"}},
@@ -412,7 +412,7 @@ TEST_F(HistoricalTests, TestMetadataListDatasetConditions) {
 
   databento::Historical target{kApiKey, "localhost",
                                static_cast<std::uint16_t>(port)};
-  const auto conditions = target.MetadataListDatasetConditions(
+  const auto conditions = target.MetadataGetDatasetCondition(
       dataset::kXnasItch, "2022-11-06", "2022-11-10");
   ASSERT_EQ(conditions.size(), 4);
   EXPECT_EQ(conditions[0].date, "2022-11-07");