Skip to content

Commit 2daf9a6

Browse files
committed
MOD: Align list_fields optional dataset param
1 parent a665007 commit 2daf9a6

File tree

4 files changed

+14
-20
lines changed

4 files changed

+14
-20
lines changed

databento/historical/api/batch.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ def submit_job(
113113
validate_enum(stype_in, SType, "stype_in")
114114
validate_enum(stype_out, SType, "stype_out")
115115

116-
params: List[Tuple[str, str]] = BentoHttpAPI._timeseries_params(
116+
params: List[Tuple[str, Optional[str]]] = BentoHttpAPI._timeseries_params(
117117
dataset=dataset,
118118
start=start,
119119
end=end,

databento/historical/api/metadata.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ def list_datasets(
8383

8484
def list_schemas(
8585
self,
86-
dataset: Union[Dataset, str],
86+
dataset: Optional[Union[Dataset, str]] = None,
8787
start_date: Optional[Union[date, str]] = None,
8888
end_date: Optional[Union[date, str]] = None,
8989
) -> List[str]:
@@ -94,7 +94,7 @@ def list_schemas(
9494
9595
Parameters
9696
----------
97-
dataset : Dataset or str
97+
dataset : Dataset or str, optional
9898
The dataset code (string identifier) for the request.
9999
start_date : date or str, optional
100100
The start date (UTC) for the request range.
@@ -228,7 +228,7 @@ def list_unit_prices(
228228
validate_maybe_enum(schema, Schema, "schema")
229229
validate_maybe_enum(mode, FeedMode, "mode")
230230

231-
params: List[Tuple[str, str]] = [
231+
params: List[Tuple[str, Optional[str]]] = [
232232
("dataset", enum_or_str_lowercase(dataset, "dataset")),
233233
("mode", maybe_enum_or_str_lowercase(mode, "mode")),
234234
("schema", maybe_enum_or_str_lowercase(schema, "schema")),
@@ -289,7 +289,7 @@ def get_record_count(
289289
validate_enum(schema, Schema, "schema")
290290
validate_enum(stype_in, SType, "stype_in")
291291

292-
params: List[Tuple[str, str]] = [
292+
params: List[Tuple[str, Optional[str]]] = [
293293
("dataset", enum_or_str_lowercase(dataset, "dataset")),
294294
("symbols", maybe_symbols_list_to_string(symbols)),
295295
("schema", Schema(schema).value),
@@ -354,7 +354,7 @@ def get_billable_size(
354354
validate_enum(schema, Schema, "schema")
355355
validate_enum(stype_in, SType, "stype_in")
356356

357-
params: List[Tuple[str, str]] = super()._timeseries_params(
357+
params: List[Tuple[str, Optional[str]]] = super()._timeseries_params(
358358
dataset=dataset,
359359
start=start,
360360
end=end,
@@ -421,7 +421,7 @@ def get_cost(
421421
validate_enum(schema, Schema, "schema")
422422
validate_enum(stype_in, SType, "stype_in")
423423

424-
params: List[Tuple[str, str]] = super()._timeseries_params(
424+
params: List[Tuple[str, Optional[str]]] = super()._timeseries_params(
425425
dataset=dataset,
426426
start=start,
427427
end=end,

databento/historical/api/timeseries.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ def stream(
7979
validate_enum(stype_in, SType, "stype_in")
8080
validate_enum(stype_out, SType, "stype_out")
8181

82-
params: List[Tuple[str, str]] = BentoHttpAPI._timeseries_params(
82+
params: List[Tuple[str, Optional[str]]] = BentoHttpAPI._timeseries_params(
8383
dataset=dataset,
8484
start=start,
8585
end=end,
@@ -171,7 +171,7 @@ async def stream_async(
171171
validate_enum(stype_in, SType, "stype_in")
172172
validate_enum(stype_out, SType, "stype_out")
173173

174-
params: List[Tuple[str, str]] = BentoHttpAPI._timeseries_params(
174+
params: List[Tuple[str, Optional[str]]] = BentoHttpAPI._timeseries_params(
175175
dataset=dataset,
176176
start=start,
177177
end=end,

databento/historical/http.py

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -49,18 +49,12 @@ def _timeseries_params(
4949
limit: Optional[int] = None,
5050
stype_in: SType,
5151
stype_out: SType = SType.PRODUCT_ID,
52-
) -> List[Tuple[str, str]]:
53-
# Parse inputs
54-
dataset = enum_or_str_lowercase(dataset, "dataset")
55-
start = maybe_datetime_to_string(start)
56-
end = maybe_datetime_to_string(end)
57-
symbols = maybe_symbols_list_to_string(symbols)
58-
52+
) -> List[Tuple[str, Optional[str]]]:
5953
params: List[Tuple[str, Any]] = [
60-
("dataset", dataset),
61-
("start", start),
62-
("end", end),
63-
("symbols", symbols),
54+
("dataset", enum_or_str_lowercase(dataset, "dataset")),
55+
("start", maybe_datetime_to_string(start)),
56+
("end", maybe_datetime_to_string(end)),
57+
("symbols", maybe_symbols_list_to_string(symbols)),
6458
("schema", schema.value),
6559
("stype_in", stype_in.value),
6660
("stype_out", stype_out.value),

0 commit comments

Comments
 (0)