MOD: Improve Live client error reporting

Author: nmacholl

CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 0.44.1 - TBD
+
+#### Enhancements
+- Improved exception messages emitted by the `Live` client to always include contents of any `ErrorMsg` sent by the gateway
+
 ## 0.44.0 - 2024-10-22
 
 #### Enhancements

databento/live/protocol.py

@@ -195,21 +195,20 @@ def connection_lost(self, exc: Exception | None) -> None:
         """
         super().connection_lost(exc)
         if not self.disconnected.done():
-            if exc is None:
-                logger.info("connection closed")
-                if self._error_msgs:
-                    error_msg = ", ".join(self._error_msgs)
-                    if len(self._error_msgs) > 1:
-                        error_msg = f"The following errors occurred: {error_msg}"
-                    self._error_msgs.clear()
-                    self.disconnected.set_exception(
-                        BentoError(error_msg),
-                    )
-                else:
-                    self.disconnected.set_result(None)
-            else:
+            if self._error_msgs:
+                error_msg = ", ".join(self._error_msgs)
+                if len(self._error_msgs) > 1:
+                    error_msg = f"The following errors occurred: {error_msg}"
+                self._error_msgs.clear()
+
+                logger.error("gateway error: %s", exc)
+                self.disconnected.set_exception(BentoError(error_msg))
+            elif exc is not None:
                 logger.error("connection lost: %s", exc)
                 self.disconnected.set_exception(exc)
+            else:
+                logger.info("connection closed")
+                self.disconnected.set_result(None)
 
     def eof_received(self) -> bool | None:
         """