Skip to content

Commit 6bceba0

Browse files
cjdsellersnmacholl
authored andcommitted
MOD: Allow optional end for batch.submit_job
1 parent 008872f commit 6bceba0

File tree

4 files changed

+43
-50
lines changed

4 files changed

+43
-50
lines changed

databento/historical/api/batch.py

Lines changed: 21 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -10,35 +10,28 @@
1010
import aiohttp
1111
import pandas as pd
1212
import requests
13-
from databento.common.enums import (
14-
Compression,
15-
Dataset,
16-
Delivery,
17-
Encoding,
18-
Packaging,
19-
Schema,
20-
SplitDuration,
21-
SType,
22-
)
23-
from databento.common.parsing import (
24-
datetime_to_string,
25-
optional_datetime_to_string,
26-
optional_symbols_list_to_string,
27-
optional_values_list_to_string,
28-
)
29-
from databento.common.validation import (
30-
validate_enum,
31-
validate_path,
32-
validate_semantic_string,
33-
)
34-
from databento.historical.api import API_VERSION
35-
from databento.historical.http import (
36-
BentoHttpAPI,
37-
check_http_error,
38-
check_http_error_async,
39-
)
4013
from requests.auth import HTTPBasicAuth
4114

15+
from databento.common.enums import Compression
16+
from databento.common.enums import Dataset
17+
from databento.common.enums import Delivery
18+
from databento.common.enums import Encoding
19+
from databento.common.enums import Packaging
20+
from databento.common.enums import Schema
21+
from databento.common.enums import SplitDuration
22+
from databento.common.enums import SType
23+
from databento.common.parsing import datetime_to_string
24+
from databento.common.parsing import optional_datetime_to_string
25+
from databento.common.parsing import optional_symbols_list_to_string
26+
from databento.common.parsing import optional_values_list_to_string
27+
from databento.common.validation import validate_enum
28+
from databento.common.validation import validate_path
29+
from databento.common.validation import validate_semantic_string
30+
from databento.historical.api import API_VERSION
31+
from databento.historical.http import BentoHttpAPI
32+
from databento.historical.http import check_http_error
33+
from databento.historical.http import check_http_error_async
34+
4235

4336
logger = logging.getLogger(__name__)
4437

@@ -129,7 +122,7 @@ def submit_job(
129122
params: List[Tuple[str, Optional[str]]] = [
130123
("dataset", validate_semantic_string(dataset, "dataset")),
131124
("start", datetime_to_string(start)),
132-
("end", datetime_to_string(end)),
125+
("end", optional_datetime_to_string(end)),
133126
("symbols", str(symbols_list)),
134127
("schema", str(validate_enum(schema, Schema, "schema"))),
135128
("stype_in", str(stype_in_valid)),

databento/historical/api/metadata.py

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,21 +2,22 @@
22
from typing import Any, Dict, List, Optional, Tuple, Union
33

44
import pandas as pd
5-
from databento.common.enums import Dataset, Encoding, FeedMode, Schema, SType
6-
from databento.common.parsing import (
7-
datetime_to_string,
8-
optional_date_to_string,
9-
optional_datetime_to_string,
10-
optional_symbols_list_to_string,
11-
)
12-
from databento.common.validation import (
13-
validate_enum,
14-
validate_maybe_enum,
15-
validate_semantic_string,
16-
)
5+
from requests import Response
6+
7+
from databento.common.enums import Dataset
8+
from databento.common.enums import Encoding
9+
from databento.common.enums import FeedMode
10+
from databento.common.enums import Schema
11+
from databento.common.enums import SType
12+
from databento.common.parsing import datetime_to_string
13+
from databento.common.parsing import optional_date_to_string
14+
from databento.common.parsing import optional_datetime_to_string
15+
from databento.common.parsing import optional_symbols_list_to_string
16+
from databento.common.validation import validate_enum
17+
from databento.common.validation import validate_maybe_enum
18+
from databento.common.validation import validate_semantic_string
1719
from databento.historical.api import API_VERSION
1820
from databento.historical.http import BentoHttpAPI
19-
from requests import Response
2021

2122

2223
class MetadataHttpAPI(BentoHttpAPI):

databento/historical/api/symbology.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
from datetime import date
22
from typing import Any, Dict, List, Optional, Tuple, Union
33

4+
from requests import Response
5+
46
from databento.common.enums import SType
5-
from databento.common.parsing import (
6-
datetime_to_date_string,
7-
optional_date_to_string,
8-
optional_symbols_list_to_string,
9-
)
10-
from databento.common.validation import validate_enum, validate_semantic_string
7+
from databento.common.parsing import datetime_to_date_string
8+
from databento.common.parsing import optional_date_to_string
9+
from databento.common.parsing import optional_symbols_list_to_string
10+
from databento.common.validation import validate_enum
11+
from databento.common.validation import validate_semantic_string
1112
from databento.historical.api import API_VERSION
1213
from databento.historical.http import BentoHttpAPI
13-
from requests import Response
1414

1515

1616
class SymbologyHttpAPI(BentoHttpAPI):
@@ -63,7 +63,7 @@ def resolve(
6363
"""
6464
stype_in_valid = validate_enum(stype_in, SType, "stype_in")
6565
symbols_list = optional_symbols_list_to_string(symbols, stype_in_valid)
66-
params: List[Tuple[str, str]] = [
66+
params: List[Tuple[str, Optional[str]]] = [
6767
("dataset", validate_semantic_string(dataset, "dataset")),
6868
("symbols", symbols_list),
6969
("stype_in", str(stype_in_valid)),

databento/historical/api/timeseries.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
import pandas as pd
1010

1111
from databento.common.dbnstore import DBNStore
12-
from databento.common.deprecated import deprecated
1312
from databento.common.enums import Compression
1413
from databento.common.enums import Dataset
1514
from databento.common.enums import Encoding

0 commit comments

Comments
 (0)