MOD: Improve start/end parameter parsing

Author: Zach Banks

databento/common/parsing.py

@@ -199,7 +199,12 @@ def datetime_to_string(value: Union[pd.Timestamp, date, str, int]) -> str:
     str
 
     """
-    return str(pd.to_datetime(value)).replace(" ", "T")
+    if isinstance(value, str):
+        return value
+    elif isinstance(value, int):
+        return str(value)
+    else:
+        return pd.to_datetime(value).isoformat()
 
 
 def datetime_to_date_string(value: Union[pd.Timestamp, date, str, int]) -> str:
@@ -216,7 +221,12 @@ def datetime_to_date_string(value: Union[pd.Timestamp, date, str, int]) -> str:
     str
 
     """
-    return str(pd.to_datetime(value).date())
+    if isinstance(value, str):
+        return value
+    elif isinstance(value, int):
+        return str(value)
+    else:
+        return pd.to_datetime(value).date().isoformat()
 
 
 def optional_datetime_to_string(

tests/test_common_parsing.py

@@ -173,7 +173,7 @@ def test_maybe_date_to_string_give_valid_values_returns_expected_results(
         "value, expected",
         [
             [None, None],
-            [1604782791000000000, "2020-11-07T20:59:51"],
+            [1604782791000000000, "1604782791000000000"],
             ["2020-11-07T20:59:51", "2020-11-07T20:59:51"],
             [dt.date(2020, 12, 28), "2020-12-28T00:00:00"],
             [pd.to_datetime("2020-12-28T23:12:01.123"), "2020-12-28T23:12:01.123000"],

tests/test_historical_batch.py

@@ -85,8 +85,8 @@ def test_batch_submit_job_sends_expected_request(
         )
         assert call["params"] == [
             ("dataset", "GLBX.MDP3"),
-            ("start", "2020-12-28T12:00:00"),
-            ("end", "2020-12-29T00:00:00"),
+            ("start", "2020-12-28T12:00"),
+            ("end", "2020-12-29"),
             ("symbols", "ESH1"),
             ("schema", "trades"),
             ("stype_in", "native"),
@@ -125,7 +125,7 @@ def test_batch_list_jobs_sends_expected_request(
         )
         assert call["params"] == [
             ("states", "received,queued,processing,done"),
-            ("since", "2022-01-01T00:00:00"),
+            ("since", "2022-01-01"),
         ]
         assert call["timeout"] == (100, 100)
         assert isinstance(call["auth"], requests.auth.HTTPBasicAuth)

tests/test_historical_metadata.py

@@ -254,8 +254,8 @@ def test_get_record_count_sends_expected_request(
             ("dataset", "GLBX.MDP3"),
             ("symbols", "ESH1"),
             ("schema", "mbo"),
-            ("start", "2020-12-28T12:00:00"),
-            ("end", "2020-12-29T00:00:00"),
+            ("start", "2020-12-28T12:00"),
+            ("end", "2020-12-29"),
             ("stype_in", "native"),
             ("limit", "1000000"),
         ]
@@ -293,8 +293,8 @@ def test_get_billable_size_sends_expected_request(
         )
         assert call["params"] == [
             ("dataset", "GLBX.MDP3"),
-            ("start", "2020-12-28T12:00:00"),
-            ("end", "2020-12-29T00:00:00"),
+            ("start", "2020-12-28T12:00"),
+            ("end", "2020-12-29"),
             ("symbols", "ESH1"),
             ("schema", "mbo"),
             ("stype_in", "native"),
@@ -332,8 +332,8 @@ def test_get_cost_sends_expected_request(self, mocker: MockerFixture) -> None:
         )
         assert call["params"] == [
             ("dataset", "GLBX.MDP3"),
-            ("start", "2020-12-28T12:00:00"),
-            ("end", "2020-12-29T00:00:00"),
+            ("start", "2020-12-28T12:00"),
+            ("end", "2020-12-29"),
             ("symbols", "ESH1"),
             ("schema", "mbo"),
             ("stype_in", "native"),

tests/test_historical_timeseries.py

@@ -91,8 +91,8 @@ def test_get_range_sends_expected_request(
         )
         assert call["params"] == [
             ("dataset", "GLBX.MDP3"),
-            ("start", "2020-12-28T12:00:00"),
-            ("end", "2020-12-29T00:00:00"),
+            ("start", "2020-12-28T12:00"),
+            ("end", "2020-12-29"),
             ("symbols", "ES.c.0"),
             ("schema", "trades"),
             ("stype_in", "smart"),
@@ -144,8 +144,8 @@ def test_get_range_with_limit_sends_expected_request(
         )
         assert call["params"] == [
             ("dataset", "GLBX.MDP3"),
-            ("start", "2020-12-28T12:00:00"),
-            ("end", "2020-12-29T00:00:00"),
+            ("start", "2020-12-28T12:00"),
+            ("end", "2020-12-29"),
             ("symbols", "ESH1"),
             ("schema", "trades"),
             ("stype_in", "native"),