Skip to content

Commit 8d921a4

Browse files
committed
MOD: Standardize batch submit_job param ordering
1 parent fb9f2c2 commit 8d921a4

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

databento/historical/api/batch.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ def submit_job(
3535
dataset: Union[Dataset, str],
3636
start: Union[pd.Timestamp, date, str, int],
3737
end: Union[pd.Timestamp, date, str, int],
38+
symbols: Optional[Union[List[str], str]],
3839
schema: Union[Schema, str],
39-
symbols: Optional[Union[List[str], str]] = None,
4040
encoding: Union[Encoding, str] = "dbz",
4141
compression: Optional[Union[Compression, str]] = None,
4242
split_duration: Union[SplitDuration, str] = "day",
@@ -64,7 +64,7 @@ def submit_job(
6464
The end datetime of the request time range (exclusive).
6565
Assumes UTC as timezone unless passed a tz-aware object.
6666
If an integer is passed, then this represents nanoseconds since UNIX epoch.
67-
symbols : List[Union[str, int]] or str, optional
67+
symbols : List[Union[str, int]] or str
6868
The product symbols to filter for. Takes up to 2,000 symbols per request.
6969
If more than 1 symbol is specified, the data is merged and sorted by time.
7070
If `*` or ``None`` then will be for **all** symbols.

databento/historical/http.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ def _timeseries_params(
5454
("dataset", enum_or_str_lowercase(dataset, "dataset")),
5555
("start", maybe_datetime_to_string(start)),
5656
("end", maybe_datetime_to_string(end)),
57-
("symbols", maybe_symbols_list_to_string(symbols)),
57+
("symbols", maybe_symbols_list_to_string(symbols) or "*"),
5858
("schema", schema.value),
5959
("stype_in", stype_in.value),
6060
("stype_out", stype_out.value),

0 commit comments

Comments
 (0)