MOD: Live subcribe single write to transport

Author: nmacholl

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 #### Bug fixes
 - Fixed an issue where the `Live` client would not raise an exception when reading an incompatible DBN version
+- Fixed an issue where sending lots of subscriptions could cause a `BufferError`
 
 ## 0.24.1 - 2023-12-15
 

databento/live/protocol.py

@@ -283,6 +283,7 @@ def subscribe(
         stype_in_valid = validate_enum(stype_in, SType, "stype_in")
         symbols_list = optional_symbols_list_to_list(symbols, stype_in_valid)
 
+        subscription_bytes: list[bytes] = []
         for batch in chunk(symbols_list, SYMBOL_LIST_BATCH_SIZE):
             batch_str = ",".join(batch)
             message = SubscriptionRequest(
@@ -291,8 +292,9 @@ def subscribe(
                 symbols=batch_str,
                 start=optional_datetime_to_unix_nanoseconds(start),
             )
+            subscription_bytes.append(bytes(message))
 
-            self.transport.write(bytes(message))
+        self.transport.writelines(subscription_bytes)
 
     def start(
         self,

databento/live/session.py

@@ -477,7 +477,7 @@ async def _connect_task(
         )
 
         try:
-            await asyncio.wait_for(
+            session_id = await asyncio.wait_for(
                 protocol.authenticated,
                 timeout=AUTH_TIMEOUT_SECONDS,
             )
@@ -488,6 +488,8 @@ async def _connect_task(
             ) from None
         except ValueError as exc:
             raise BentoError(f"User authentication failed: {exc!s}") from None
+        else:
+            logger.info("assigned session id %s", session_id)
 
         logger.info(
             "authentication with remote gateway completed",