DEL: Remove default_value from symbology.resove

Author: nmacholl

CHANGELOG.md

@@ -9,6 +9,9 @@
 #### Bug fixes
 - Fixed an issue where no disconnection exception were raised when iterating the `Live` client.
 
+#### Breaking changes
+- Removed `default_value` parameter from `Historical.symbology.resolve`
+
 ## 0.19.1 - 2023-09-08
 
 #### Bug fixes

databento/historical/api/symbology.py

@@ -33,7 +33,6 @@ def resolve(
         stype_out: SType | str,
         start_date: date | str,
         end_date: date | str | None = None,
-        default_value: str = "",
     ) -> dict[str, Any]:
         """
         Request symbology mappings resolution from Databento.
@@ -54,8 +53,6 @@ def resolve(
             The start date (UTC) of the request time range (inclusive).
         end_date : date or str, optional
             The end date (UTC) of the request time range (exclusive).
-        default_value : str, default '' (empty string)
-            The default value to return if a symbol cannot be resolved.
 
         Returns
         -------
@@ -73,7 +70,6 @@ def resolve(
             "stype_out": str(validate_enum(stype_out, SType, "stype_out")),
             "start_date": datetime_to_date_string(start_date),
             "end_date": optional_date_to_string(end_date),
-            "default_value": default_value,
         }
 
         response: Response = self._post(

tests/test_historical_client.py

@@ -126,7 +126,6 @@ def test_re_request_symbology_makes_expected_request(
         "stype_out": "instrument_id",
         "start_date": "2020-12-28",
         "end_date": "2020-12-29",
-        "default_value": "",
     }
     assert sorted(call["headers"].keys()) == ["accept", "user-agent"]
     assert call["headers"]["accept"] == "application/json"