Skip to content

Initial inclusion of the mqtt library into the python data source connector #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dmoore247 merged 8 commits into from
Sep 25, 2025
Merged

Initial inclusion of the mqtt library into the python data source connector #10

dmoore247 merged 8 commits into from
Sep 25, 2025

Conversation

@jefferyann-db
Copy link
Contributor

@jefferyann-db jefferyann-db commented Sep 5, 2025

#In PR:

  • mqtt stream read
  • test fixtures to ensure message delivery
  • enhance readme.md
  • remove contribution.md

#TODO:

  • add a requirements.txt to handle paho-client installation
  • build sync for stream writes
  • add demo notebooks, collaterals
  • checkmark for capabilities i.e. read, write, readstream, writestream

@dmoore247
Copy link
Collaborator

dmoore247 commented Sep 5, 2025

Thanks @jefferyann-db and @ggasg !!

What about the Makefile and the command make test, make style, make dev, make check?
The Automated check ran the zipdcm test; We'd want to find a way to un-couple each data source.

@jefferyann-db
Copy link
Contributor Author

jefferyann-db commented Sep 11, 2025

Thanks @jefferyann-db and @ggasg !!

What about the Makefile and the command make test, make style, make dev, make check? The Automated check ran the zipdcm test; We'd want to find a way to un-couple each data source.

@dmoore247 That should be added to the pr now. Still small pr but once approved we would add enhancements in the subsequent PRs.

dmoore247
dmoore247 requested changes Sep 11, 2025
View reviewed changes
Copy link
Collaborator

@dmoore247 dmoore247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@jefferyann-db
Copy link
Contributor Author

jefferyann-db commented Sep 15, 2025

@dmoore247 added a new push with license change and changes implemented

dmoore247
dmoore247 approved these changes Sep 25, 2025
View reviewed changes
Copy link
Collaborator

@dmoore247 dmoore247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Let's fast follow with CICD for the mqtt lib.

@dmoore247 dmoore247 merged commit e57fbda into main Sep 25, 2025
1 check passed
@dmoore247 dmoore247 deleted the feat/mqttv1 branch September 25, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmoore247 dmoore247 dmoore247 approved these changes

@ggasg ggasg Awaiting requested review from ggasg

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jefferyann-db @dmoore247