refactor: remove pluginRegistry for now (will be attacked on another pr)

Author: ditadi

apps/dev-playground/client/src/appKitTypes.d.ts

@@ -3,34 +3,6 @@
 import "@databricks/app-kit-ui/react";
 
 declare module "@databricks/app-kit-ui/react" {
-  interface PluginRegistry {
-    "analytics": {
-      "/users/me/query/:query_key": {
-       chunk_index: number
-       row_offset: number
-       row_count: number
-       data: any[]
-      };
-      "/query/:query_key": {
-       chunk_index: number
-       row_offset: number
-       row_count: number
-       data: any[]
-      };
-    };
-    "reconnect": {
-      "/": {
-       message: string
-      };
-      "/stream": {
-       type: number
-       count: number
-       total: number
-       timestamp: string
-       content: string
-      };
-    };
-  }
   interface QueryRegistry {
     apps_list: {
         name: "apps_list";

packages/app-kit-ui/src/react/hooks/index.ts

@@ -6,4 +6,3 @@ export type {
 } from "./types";
 export { useAnalyticsQuery } from "./use-analytics-query";
 export { useChartData } from "./use-chart-data";
-export { useCustomPlugin } from "./use-custom-plugin";

packages/app-kit-ui/src/react/hooks/types.ts

@@ -77,21 +77,3 @@ export type InferParams<K> = K extends AugmentedRegistry<QueryRegistry>
 export interface PluginRegistry {
   [key: string]: Record<string, any>;
 }
-
-export type PluginName = AugmentedRegistry<PluginRegistry> extends never
-  ? string
-  : AugmentedRegistry<PluginRegistry>;
-
-export type PluginRoutes<P extends PluginName> =
-  P extends AugmentedRegistry<PluginRegistry>
-    ? AugmentedRegistry<PluginRegistry[P]>
-    : string;
-
-export type RouteResponse<
-  P extends PluginName,
-  R extends PluginRoutes<P>,
-> = P extends keyof PluginRegistry
-  ? R extends keyof PluginRegistry[P]
-    ? PluginRegistry[P][R]
-    : unknown
-  : unknown;

packages/app-kit-ui/src/react/hooks/use-custom-plugin.ts

@@ -12,7 +12,6 @@ const rootDir = positionalArgs[0] || process.cwd();
 const outFile =
   positionalArgs[1] || path.join(process.cwd(), "client/src/appKitTypes.d.ts");
 
-const pluginEntryPoint = path.join(rootDir, "server/index.ts");
 const queryFolder = path.join(rootDir, "config/queries");
 
 const warehouseId = positionalArgs[2] || process.env.DATABRICKS_WAREHOUSE_ID;
@@ -21,7 +20,6 @@ if (!warehouseId) {
 }
 
 await generateFromEntryPoint({
-  pluginEntryPoint,
   queryFolder,
   outFile,
   warehouseId,

packages/app-kit/bin/generate-types.ts

@@ -7,7 +7,6 @@ import type { PluginPhase } from "shared";
 import { Plugin, toPlugin } from "../plugin";
 import { instrumentations } from "../telemetry";
 import { databricksClientMiddleware, isRemoteServerEnabled } from "../utils";
-import { generatePluginRegistryTypes } from "../utils/type-generator";
 import { DevModeManager } from "./dev-mode";
 import type { ServerConfig } from "./types";
 import { getQueries, getRoutes } from "./utils";

packages/app-kit/src/server/index.ts

@@ -1,44 +1,16 @@
 import fs from "node:fs";
-import path from "node:path";
 import dotenv from "dotenv";
-import ts from "typescript";
-import {
-  extractRoutesFromFile,
-  findPluginFiles,
-  getAllImportedFiles,
-  type PluginRoutes,
-} from "./plugin-registry";
 import { generateQueriesFromExplain, type QuerySchema } from "./query-registry";
 
 dotenv.config();
 
 /**
- * Generate type declarations for PluginRegistry and QueryRegistry
+ * Generate type declarations for QueryRegistry
  * Create the d.ts file from the plugin routes and query schemas
- * @param plugins - the list of plugin routes
  * @param querySchemas - the list of query schemas
  * @returns - the type declarations as a string
  */
-function generateTypeDeclarations(
-  plugins: PluginRoutes[],
-  querySchemas: QuerySchema[] = [],
-): string {
-  const registryEntries = plugins
-    .map(({ pluginName, routes }) => {
-      const routeEntries = routes
-        .map(({ path, responseType }) => {
-          const indentedType = responseType
-            .split("\n")
-            .map((line, i) => (i === 0 ? line : `      ${line}`))
-            .join("\n");
-          return `      "${path}": ${indentedType}`;
-        })
-        .join(";\n");
-
-      return `    "${pluginName}": {\n${routeEntries};\n    }`;
-    })
-    .join(";\n");
-
+function generateTypeDeclarations(querySchemas: QuerySchema[] = []): string {
   const queryEntries = querySchemas
     .map(({ name, type }) => {
       const indentedType = type
@@ -56,9 +28,6 @@ function generateTypeDeclarations(
 import "@databricks/app-kit-ui/react";
 
 declare module "@databricks/app-kit-ui/react" {
-  interface PluginRegistry {
-${registryEntries};
-  }
   interface QueryRegistry {${querySection}}
 }
 `;
@@ -72,61 +41,22 @@ ${registryEntries};
  * @param options.querySchemaFile - optional path to query schema file (e.g. config/queries/schema.ts)
  */
 export async function generateFromEntryPoint(options: {
-  pluginEntryPoint: string;
   outFile: string;
   queryFolder?: string;
   warehouseId: string;
   noCache?: boolean;
 }) {
-  const { pluginEntryPoint, outFile, queryFolder, warehouseId, noCache } =
-    options;
+  const { outFile, queryFolder, warehouseId, noCache } = options;
 
   console.log("\n[AppKit] Starting type generation...\n");
 
-  const allFiles = getAllImportedFiles(pluginEntryPoint);
-
-  const configPath = ts.findConfigFile(
-    path.dirname(pluginEntryPoint),
-    ts.sys.fileExists,
-    "tsconfig.json",
-  );
-
-  const configFile = configPath
-    ? ts.readConfigFile(configPath, ts.sys.readFile)
-    : { config: {} };
-
-  const parsedConfig = ts.parseJsonConfigFileContent(
-    configFile.config,
-    ts.sys,
-    path.dirname(configPath || pluginEntryPoint),
-  );
-
-  const program = ts.createProgram(allFiles, {
-    ...parsedConfig.options,
-    noEmit: true,
-  });
-
-  const pluginFiles = findPluginFiles(allFiles, program);
-
-  const allPluginRoutes: PluginRoutes[] = [];
-
-  for (const pluginFile of pluginFiles) {
-    const routes = extractRoutesFromFile(pluginFile, program);
-    if (routes) {
-      allPluginRoutes.push(routes);
-    }
-  }
-
   let queryRegistry: QuerySchema[] = [];
   if (queryFolder)
     queryRegistry = await generateQueriesFromExplain(queryFolder, warehouseId, {
       noCache,
     });
 
-  const typeDeclarations = generateTypeDeclarations(
-    allPluginRoutes,
-    queryRegistry,
-  );
+  const typeDeclarations = generateTypeDeclarations(queryRegistry);
 
   fs.writeFileSync(outFile, typeDeclarations, "utf-8");